@@ -105,6 +105,19 @@ helper :network_page_for do |user| "https://github.com/#{user}/#{project}/network" end +helper :has_launchy? do |blk| + begin + gem 'launchy' + require 'launchy' + blk.call + rescue Gem::LoadError + STDERR.puts "Sorry, you need to install launchy: `gem install launchy`" + end +end + helper :open do |url| - Launchy::Browser.new.visit url + has_launchy? proc { + Launchy::Browser.new.visit url + } end + commands/helpers.rb @@ -21,5 +21,5 @@ Gem::Specification.new do |s| s.rubygems_version = %q{1.1.1} s.summary = %q{The official `github` command line helper for simplifying your GitHub experience.} - s.add_dependency(%q<launchy>, [">= 0"]) + # s.add_dependency(%q<launchy>, [">= 0"]) end github-gem.gemspec @@ -3,7 +3,6 @@ require 'extensions' require 'github/command' require 'github/helper' require 'rubygems' -require 'launchy' ## # Starting simple. lib/github.rb @@ -191,11 +191,21 @@ remote.nex3.url git://github.com/nex3/github-gem.git end helper :open do - it "should launch the URL" do - Launchy::Browser.next_instance.tap do |browser| - browser.should_receive(:my_os_family).any_number_of_times.and_return :windows # avoid forking - browser.should_receive(:system).with("/usr/bin/open http://www.google.com") + it "should launch the URL when Launchy is installed" do + begin + require 'launchy' + @helper.should_receive(:gem).with('launchy') + # @helper.should_receive(:has_launchy?).and_return { |blk| blk.call } + Launchy::Browser.next_instance.should_receive(:visit).with("http://www.google.com") + @helper.open "http://www.google.com" + rescue LoadError + fail "Launchy is required for this spec" end + end + + it "should fail when Launchy is not installed" do + @helper.should_receive(:gem).with('launchy').and_raise(Gem::LoadError) + STDERR.should_receive(:puts).with("Sorry, you need to install launchy: `gem install launchy`") @helper.open "http://www.google.com" end end spec/helper_spec.rb 9f7f232c2e80513be39410da93392fc8b9d47461 b8fb20e08848a6a5668c285aa032315ebfd4ff33 Kevin Ballard kevin@sb.org http://github.com/mojombo/github-gem/commit/3ba039ba129c08e77f60e2940ad2763905383f7a 3ba039ba129c08e77f60e2940ad2763905383f7a 2008-07-07T14:54:36-07:00 2008-07-07T14:54:36-07:00 Merge commit 'snowblink/remove_launchy_requirement' * commit 'snowblink/remove_launchy_requirement': Reverting change to spec/spec_helper.rb. The change was originally made so the tests could run on earlier version of rspec (<1.1.4) Removing requirement for launchy. It will enable installation of gem with reduced functionality. 3eef890b253ca5c18e081b38b887c5bd12e60f9b Kevin Ballard kevin@sb.org