Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long date format for Czech #2016

Closed
wants to merge 1 commit into from

Conversation

radekdostal
Copy link
Contributor

Removed nonbreaking spaces from "L" long date format.

@ichernev
Copy link
Contributor

@petrbela what do you think?
@radekdostal you need to change the tests too.

Removed nonbreaking spaces from "L" long date format.
@radekdostal
Copy link
Contributor Author

@ichernev Tests were changed.

@petrbela
Copy link
Contributor

👍

@ichernev ichernev closed this Nov 17, 2014
ichernev added a commit that referenced this pull request Nov 17, 2014
Fix long date format for Czech
@enumag
Copy link

enumag commented Feb 13, 2016

@ichernev This should be reverted. The correct czech format is actually WITH the spaces. It is often use without them but that's a mistake. Should I send pull request?

@petrbela
Copy link
Contributor

According to https://cs.wikipedia.org/wiki/Wikipedie:Typografick%C3%A9_rady#Datum, it should be either 23. 2. 2016 (with spaces) or 23.02.2016 (with padded 0 without spaces). I think the first form should be what format('l') produces, and the second one format('L').

I think the norm will change again in the next iteration anyway, but for now, if you can make a PR fixing the l format, I think we should be good.

@enumag enumag mentioned this pull request Mar 2, 2016
ichernev added a commit to ichernev/moment that referenced this pull request Jun 14, 2016
@ichernev ichernev mentioned this pull request Jun 14, 2016
ichernev added a commit that referenced this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants