From 2f305e5a1036d7a0221a6925eecbef144f8436cb Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Thu, 22 Jun 2023 09:51:21 +0800 Subject: [PATCH] MDL-78542 mod_url: clicktoopen lang string fix - Improve the grammatical structure of the lang string. - Remove the mention of "link", for sighted users, it should already be obvious that it's a link. For screen reader users, screen readers already announce links. So it would be confusing for them to hear something like "Click 'Moodle.org, link' link to open resource" --- mod/url/lang/en/url.php | 2 +- mod/url/tests/behat/url_activity_completion.feature | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/mod/url/lang/en/url.php b/mod/url/lang/en/url.php index dd2934ff37b1f..a8ca6fb0ea2f3 100644 --- a/mod/url/lang/en/url.php +++ b/mod/url/lang/en/url.php @@ -23,7 +23,7 @@ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -$string['clicktoopen'] = 'Click {$a} link to open resource.'; +$string['clicktoopen'] = 'Click on {$a} to open the resource.'; $string['configdisplayoptions'] = 'Select all options that should be available, existing settings are not modified. Hold CTRL key to select multiple fields.'; $string['configframesize'] = 'When a web page or an uploaded file is displayed within a frame, this value is the height (in pixels) of the top frame (which contains the navigation).'; $string['configrolesinparams'] = 'Should customised role names (from the course settings) be available as variables for URL parameters?'; diff --git a/mod/url/tests/behat/url_activity_completion.feature b/mod/url/tests/behat/url_activity_completion.feature index b2da6473ff3d1..f87c4c816b5f7 100644 --- a/mod/url/tests/behat/url_activity_completion.feature +++ b/mod/url/tests/behat/url_activity_completion.feature @@ -31,7 +31,9 @@ Feature: View activity completion information in the URL resource | completionview | 1 | | display | 0 | When I am on the "Music history" "url activity" page logged in as teacher1 - Then "Music history" should have the "View" completion condition + Then "Music history" "link" should exist + And I should see "Click on Music history to open the resource." + And "Music history" should have the "View" completion condition Scenario: View automatic completion items in automatic display mode as student Given the following "activity" exists: