From bdbef7410978f5853eb14d9efc50e3011fec6724 Mon Sep 17 00:00:00 2001
From: Peter Dias <peter@moodle.com>
Date: Tue, 30 Nov 2021 14:15:09 +0800
Subject: [PATCH] MDL-72965 mod_data: Update tertiary navigation wording

- Changed text to 'Manage fields' in the primary dropdown
- Change text to 'Create a new field' in the add new field dropdown
- Add a header when on 'Manage fields' page.
---
 mod/data/classes/output/action_bar.php | 4 ++--
 mod/data/field.php                     | 1 +
 mod/data/lang/en/data.php              | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/mod/data/classes/output/action_bar.php b/mod/data/classes/output/action_bar.php
index 28ef27515ac9a..91f630b2f627e 100644
--- a/mod/data/classes/output/action_bar.php
+++ b/mod/data/classes/output/action_bar.php
@@ -61,7 +61,7 @@ public function get_fields_action_bar(bool $hasfieldselect = false, bool $hassav
         $presetslink = new moodle_url('/mod/data/field.php', ['d' => $this->id, 'mode' => 'usepreset']);
 
         $menu = [
-            $createfieldlink->out(false) => get_string('newfield', 'mod_data'),
+            $createfieldlink->out(false) => get_string('managefields', 'mod_data'),
             $importlink->out(false) => get_string('importpreset', 'mod_data'),
             $presetslink->out(false) => get_string('usestandard', 'mod_data'),
         ];
@@ -89,7 +89,7 @@ public function get_fields_action_bar(bool $hasfieldselect = false, bool $hassav
             asort($menufield);
 
             $fieldselecturl = new moodle_url('/mod/data/field.php', ['d' => $this->id, 'mode' => 'new']);
-            $fieldselect = new \single_select($fieldselecturl, 'newtype', $menufield, null, ['' => 'choosedots'],
+            $fieldselect = new \single_select($fieldselecturl, 'newtype', $menufield, null, get_string('newfield', 'data'),
                 'fieldform');
         }
 
diff --git a/mod/data/field.php b/mod/data/field.php
index bc88a606760dc..cf6a066a2f423 100644
--- a/mod/data/field.php
+++ b/mod/data/field.php
@@ -349,6 +349,7 @@
 } else {                                              /// Display the main listing of all fields
     $fieldactionbar = $actionbar->get_fields_action_bar(true, true, true);
     data_print_header($course, $cm, $data, 'fields', $fieldactionbar);
+    echo $OUTPUT->heading(get_string('managefields', 'data'), 2);
 
     if (!$DB->record_exists('data_fields', array('dataid'=>$data->id))) {
         echo $OUTPUT->notification(get_string('nofieldindatabase','data'));  // nothing in database
diff --git a/mod/data/lang/en/data.php b/mod/data/lang/en/data.php
index 899c128a4ebab..21b728e300794 100644
--- a/mod/data/lang/en/data.php
+++ b/mod/data/lang/en/data.php
@@ -244,6 +244,7 @@
 $string['listtemplate'] = 'List template';
 $string['longitude'] = 'Longitude';
 $string['manageapproved'] = 'Allow editing of approved entries';
+$string['managefields'] = 'Manage fields';
 $string['manageapproved_help'] = 'If disabled, approved entries are no longer editable or deletable by the user who added them. This setting has no effect unless \'Approval required\' is enabled.';
 $string['mapexistingfield'] = 'Map to {$a}';
 $string['mapnewfield'] = 'Create a new field';