Untitled #27
Closed
Untitled #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so we can change the cache and it will still work fine.
|
Still not sure if a slick object that is being returned by Slick.parse should not be modifiable. I believe, in terms of API, getting an object from one function (Slick.parse), modifying it and automatically and unintentionally changing the behavior of another (Slick.find) method should be strictly verboten (Solely talking Slick, not MooTools). |
|
I don't wanna include a cloneObject method inside slick and ignore the parser cache... it's one of the great features it can have for being separate from the finder! |
|
I'm waiting for input from others. I understand the issue regarding the Slick separation, however mutating function results like that should not be possible. |
…nitialize method of Swiff, Swiff uses String.uniqueID for its instance name now
…Specs are included into moo-specs.
…mplementation is broken.
…Specs are included into moo-specs.
…current frame based on the current time (turned ON by default). - forgot to add () to the isRunning call inside stop. Whops!
|
done. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the cache problem on slick and clones the parsed object so we can change it later on the injectCombinator function