From 48c6b2b4e7f88925198d82f55125e90006e26002 Mon Sep 17 00:00:00 2001 From: Tim Wienk Date: Sat, 16 Oct 2010 00:27:53 +0200 Subject: [PATCH] Fixes #413 (again). No position:absolute needed when not changing styles anyway. --- Source/Drag/Drag.Move.js | 18 ++++++++++-------- Tests/Drag/Drag.Move_(style_false).html | 1 - 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/Source/Drag/Drag.Move.js b/Source/Drag/Drag.Move.js index b592a682..d8ec090e 100644 --- a/Source/Drag/Drag.Move.js +++ b/Source/Drag/Drag.Move.js @@ -50,16 +50,18 @@ Drag.Move = new Class({ if (this.container && typeOf(this.container) != 'element') this.container = document.id(this.container.getDocument().body); - if (this.options.style && this.options.modifiers.x == "left" && this.options.modifiers.y == "top"){ - var parentStyles, - parent = element.getOffsetParent(); - var styles = element.getStyles('left', 'top'); - if (parent && styles.left == 'auto' || styles.top == 'auto'){ - element.setPosition(element.getPosition(parent)); + if (this.options.style){ + if (this.options.modifiers.x == "left" && this.options.modifiers.y == "top"){ + var parentStyles, + parent = element.getOffsetParent(); + var styles = element.getStyles('left', 'top'); + if (parent && styles.left == 'auto' || styles.top == 'auto'){ + element.setPosition(element.getPosition(parent)); + } } - } - if (element.getStyle('position') == 'static') element.setStyle('position', 'absolute'); + if (element.getStyle('position') == 'static') element.setStyle('position', 'absolute'); + } this.addEvent('start', this.checkDroppables, true); this.overed = null; diff --git a/Tests/Drag/Drag.Move_(style_false).html b/Tests/Drag/Drag.Move_(style_false).html index 6c816d69..31e421bb 100644 --- a/Tests/Drag/Drag.Move_(style_false).html +++ b/Tests/Drag/Drag.Move_(style_false).html @@ -6,7 +6,6 @@ background-color: #090; text-align: center; line-height: 30px; - position: relative; }