Develop 386 element position offset 1.3 #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndow is scrolled https://mootools.lighthouseapp.com/projects/24057/tickets/386-elementposition-is-not-working-correctly-when-the-window-is-scrolled#ticket-386-1 - adds test from ticket for hugely offset document - reverts change to Element.Position which adds scroll offset again to calculated position
|
I'll let the other guys chime in on this as it's a 1.3 issue. |
|
What's the difference between 1.2 and 1.3? As far as I know we didn't refactored Element.Postion... Maybe run the test against 1.2 as well? |
|
Ok, I updated the jsfiddle and it doesn't seem to work in 1.3... http://jsfiddle.net/TYTUy/3/ tbh I don't know much about Element.Position, but it looks ok to me.. |
|
yeah I tried looking through commits briefly to see why the else statement was added, but didn't find it... However if you do a quick comparison between 1.2 - 1.3 -- you'll see the difference |
|
@jacob: I cannot see it though: http://pastie.org/1182254 or is it somewhere else? Anyway, if its fixes the problem then it's ok of course :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lighthouse-386, Element.position is not working correctly when the window is scrolled
https://mootools.lighthouseapp.com/projects/24057/tickets/386-elementposition-is-not-working-correctly-when-the-window-is-scrolled#ticket-386-1
calculated position