Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
rustdoc: Use relative paths in source renders.
Before: doc/src/collections/home/lifthrasiir/git/rust/src/libcollections/vec.rs.html After: doc/src/collections/vec.rs.html If the source code is in the parent dirs relative to the crate root, `..` is replaced with `up` as expected. Any other error like non-UTF-8 paths or drive-relative paths falls back to the absolute path. There might be a way to improve on false negatives, but this alone should be enough for fixing #18370.
- Loading branch information
1 parent
09f04bf
commit 08fb9aa
Showing
2 changed files
with
17 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08fb9aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at lifthrasiir@08fb9aa
08fb9aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging lifthrasiir/rust/rustdoc-short-src-paths = 08fb9aa into auto
08fb9aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lifthrasiir/rust/rustdoc-short-src-paths = 08fb9aa merged ok, testing candidate = de95ad4
08fb9aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2524
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2521
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2514
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2521
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2515
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2514
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2514
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2518
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2511
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2510
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2513
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2175
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2171
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2177
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1014
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1008
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/1004
08fb9aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = de95ad4