Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
d4a3238 broke these since slice_to() and slice_from() must get character boundaries, and arbitrary needle lengths don't necessarily map to character boundaries of the haystack. This also adds new tests that would have caught this bug.
- Loading branch information
Showing
1 changed file
with
6 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
090b245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at metajack@090b245
090b245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging metajack/rust/fix-starts-with-ends-with = 090b245 into auto
090b245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metajack/rust/fix-starts-with-ends-with = 090b245 merged ok, testing candidate = 71c3f8c
090b245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2013
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2017
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1123
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1122
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2031
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1123
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1123
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2032
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1123
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1123
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/1202
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2016
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1121
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1123
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1800
090b245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 71c3f8c