Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Prevent Regex::new() from panicking when a non-AST item is repeated
This bug has also affected the regex! macro, which has caused an ICE when such an invalid expression is provided. Fixes #20208.
- Loading branch information
Showing
2 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0bd8534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at barosl@0bd8534
0bd8534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging barosl/rust/regex-repeater-panic = 0bd8534 into auto
0bd8534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: {"merge_sha": "9be54be15b4b4ba5c1b22d958d7619a5154ab469"}
0bd8534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
barosl/rust/regex-repeater-panic = 0bd8534 merged ok, testing candidate = 9be54be
0bd8534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2873
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2867
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2868
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2859
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2858
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2862
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2854
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2854
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2523
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2520
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1361
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1352
0bd8534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 9be54be
0bd8534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 9be54be