Skip to content

Commit

Permalink
Rename 'bad prefix' to 'unknown prefix'.
Browse files Browse the repository at this point in the history
  • Loading branch information
m-ou-se authored and lrh2000 committed Jun 26, 2021
1 parent d40be0f commit 0eeeebc
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
16 changes: 8 additions & 8 deletions compiler/rustc_lexer/src/lib.rs
Expand Up @@ -72,7 +72,7 @@ pub enum TokenKind {
/// prefixes are reported as errors; in earlier editions, they result in a
/// (allowed by default) lint, and are treated as regular identifier
/// tokens.
BadPrefix,
UnknownPrefix,
/// "12_u8", "1.0e-40", "b"123"". See `LiteralKind` for more details.
Literal { kind: LiteralKind, suffix_start: usize },
/// "'a"
Expand Down Expand Up @@ -330,7 +330,7 @@ impl Cursor<'_> {
let kind = RawStr { n_hashes, err };
Literal { kind, suffix_start }
}
_ => self.ident_or_bad_prefix(),
_ => self.ident_or_unknown_prefix(),
},

// Byte literal, byte string literal, raw byte string literal or identifier.
Expand Down Expand Up @@ -365,12 +365,12 @@ impl Cursor<'_> {
let kind = RawByteStr { n_hashes, err };
Literal { kind, suffix_start }
}
_ => self.ident_or_bad_prefix(),
_ => self.ident_or_unknown_prefix(),
},

// Identifier (this should be checked after other variant that can
// start as identifier).
c if is_id_start(c) => self.ident_or_bad_prefix(),
c if is_id_start(c) => self.ident_or_unknown_prefix(),

// Numeric literal.
c @ '0'..='9' => {
Expand Down Expand Up @@ -494,14 +494,14 @@ impl Cursor<'_> {
RawIdent
}

fn ident_or_bad_prefix(&mut self) -> TokenKind {
fn ident_or_unknown_prefix(&mut self) -> TokenKind {
debug_assert!(is_id_start(self.prev()));
// Start is already eaten, eat the rest of identifier.
self.eat_while(is_id_continue);
// Good prefixes must have been handled earlier. So if
// we see a prefix here, it is definitely a bad prefix.
// Known prefixes must have been handled earlier. So if
// we see a prefix here, it is definitely a unknown prefix.
match self.first() {
'#' | '"' | '\'' => BadPrefix,
'#' | '"' | '\'' => UnknownPrefix,
_ => Ident,
}
}
Expand Down
10 changes: 5 additions & 5 deletions compiler/rustc_parse/src/lexer/mod.rs
Expand Up @@ -170,15 +170,15 @@ impl<'a> StringReader<'a> {
rustc_lexer::TokenKind::Whitespace => return None,
rustc_lexer::TokenKind::Ident
| rustc_lexer::TokenKind::RawIdent
| rustc_lexer::TokenKind::BadPrefix => {
| rustc_lexer::TokenKind::UnknownPrefix => {
let is_raw_ident = token == rustc_lexer::TokenKind::RawIdent;
let is_bad_prefix = token == rustc_lexer::TokenKind::BadPrefix;
let is_unknown_prefix = token == rustc_lexer::TokenKind::UnknownPrefix;
let mut ident_start = start;
if is_raw_ident {
ident_start = ident_start + BytePos(2);
}
if is_bad_prefix {
self.report_reserved_prefix(start);
if is_unknown_prefix {
self.report_unknown_prefix(start);
}
let sym = nfc_normalize(self.str_from(ident_start));
let span = self.mk_sp(start, self.pos);
Expand Down Expand Up @@ -503,7 +503,7 @@ impl<'a> StringReader<'a> {
// using a (unknown) prefix is an error. In earlier editions, however, they
// only result in a (allowed by default) lint, and are treated as regular
// identifier tokens.
fn report_reserved_prefix(&self, start: BytePos) {
fn report_unknown_prefix(&self, start: BytePos) {
let prefix_span = self.mk_sp(start, self.pos);
let msg = format!("prefix `{}` is unknown", self.str_from_to(start, self.pos));

Expand Down
2 changes: 1 addition & 1 deletion src/librustdoc/html/highlight.rs
Expand Up @@ -413,7 +413,7 @@ impl<'a> Classifier<'a> {
},
c => c,
},
TokenKind::RawIdent | TokenKind::BadPrefix => Class::Ident,
TokenKind::RawIdent | TokenKind::UnknownPrefix => Class::Ident,
TokenKind::Lifetime { .. } => Class::Lifetime,
};
// Anything that didn't return above is the simple case where we the
Expand Down

0 comments on commit 0eeeebc

Please sign in to comment.