Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
saner parameter order for reallocation functions
Using reallocate(old_ptr, old_size, new_size, align) makes a lot more sense than reallocate(old_ptr, new_size, align, old_size) and matches up with the order used by existing platform APIs like mremap. Closes #17837 [breaking-change]
- Loading branch information
1 parent
593174b
commit 1c6fd76
Showing
3 changed files
with
34 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from eddyb
at https://github.com/thestinger/rust/commit/1c6fd76f8073a420a82d85c45ea1697fb94d214b
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/alloc = 1c6fd76 into auto
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/alloc = 1c6fd76 merged ok, testing candidate = 800e904
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1364
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1710
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1704
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1710
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1707
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1706
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1706
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1710
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1704
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1703
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1706
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1360
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1364
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/197
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/197
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/195
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from eddyb
at https://github.com/thestinger/rust/commit/1c6fd76f8073a420a82d85c45ea1697fb94d214b
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/alloc = 1c6fd76 into auto
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/alloc = 1c6fd76 merged ok, testing candidate = 41fde28
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/202
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from eddyb
at https://github.com/thestinger/rust/commit/1c6fd76f8073a420a82d85c45ea1697fb94d214b
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/alloc = 1c6fd76 into auto
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/alloc = 1c6fd76 merged ok, testing candidate = 54966aef
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1717
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1717
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1714
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1717
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1711
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1710
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1371
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1367
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1371
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/204
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/204
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/202
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from eddyb
at https://github.com/thestinger/rust/commit/1c6fd76f8073a420a82d85c45ea1697fb94d214b
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/alloc = 1c6fd76 into auto
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/alloc = 1c6fd76 merged ok, testing candidate = f010aa5
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1720
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from eddyb
at https://github.com/thestinger/rust/commit/1c6fd76f8073a420a82d85c45ea1697fb94d214b
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/alloc = 1c6fd76 into auto
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/alloc = 1c6fd76 merged ok, testing candidate = e6cfb56
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1724
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1721
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1715
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1721
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1718
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1717
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1717
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1721
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1715
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1714
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1717
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1375
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1371
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1375
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/208
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/208
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/206
1c6fd76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = e6cfb56