Skip to content

Commit

Permalink
Fix deriving Encodable trait for unit structs
Browse files Browse the repository at this point in the history
Closes #14021
  • Loading branch information
Sawyer47 committed Jun 2, 2014
1 parent 2be0c5b commit 1dc13e4
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/libsyntax/ext/deriving/encodable.rs
Expand Up @@ -175,6 +175,14 @@ fn encodable_substructure(cx: &mut ExtCtxt, trait_span: Span,
stmts.push(cx.stmt_expr(call));
}

// unit structs have no fields and need to return Ok()
if stmts.is_empty() {
let ret_ok = cx.expr(trait_span,
ExprRet(Some(cx.expr_ok(trait_span,
cx.expr_lit(trait_span, LitNil)))));
stmts.push(cx.stmt_expr(ret_ok));
}

let blk = cx.lambda_stmts_1(trait_span, stmts, blkarg);
cx.expr_method_call(trait_span,
encoder,
Expand Down
29 changes: 29 additions & 0 deletions src/test/run-pass/issue-14021.rs
@@ -0,0 +1,29 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.


extern crate serialize;

use serialize::{Encodable, Decodable};
use serialize::json;

#[deriving(Encodable, Decodable, PartialEq, Show)]
struct UnitLikeStruct;

pub fn main() {
let obj = UnitLikeStruct;
let json_str: String = json::Encoder::str_encode(&obj);

let json_object = json::from_str(json_str.as_slice());
let mut decoder = json::Decoder::new(json_object.unwrap());
let mut decoded_obj: UnitLikeStruct = Decodable::decode(&mut decoder).unwrap();

assert_eq!(obj, decoded_obj);
}

5 comments on commit 1dc13e4

@bors
Copy link
Contributor

@bors bors commented on 1dc13e4 Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at Sawyer47@1dc13e4

@bors
Copy link
Contributor

@bors bors commented on 1dc13e4 Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging Sawyer47/rust/encodable-fix = 1dc13e4 into auto

@bors
Copy link
Contributor

@bors bors commented on 1dc13e4 Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sawyer47/rust/encodable-fix = 1dc13e4 merged ok, testing candidate = 46dad76

@bors
Copy link
Contributor

@bors bors commented on 1dc13e4 Jun 2, 2014

@bors
Copy link
Contributor

@bors bors commented on 1dc13e4 Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 46dad76

Please sign in to comment.