Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check concrete type in impls with no trait
closes #16955
- Loading branch information
Showing
3 changed files
with
21 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nrc@2df3a5b
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nick29581/rust/impl = 2df3a5b into auto
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nick29581/rust/impl = 2df3a5b merged ok, testing candidate = ac307d4a
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1172
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1179
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1178
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1178
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1179
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1172
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1172
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1177
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1172
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1172
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1175
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/9
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/9
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/9
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nrc@2df3a5b
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nick29581/rust/impl = 2df3a5b into auto
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nick29581/rust/impl = 2df3a5b merged ok, testing candidate = 137325ad
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1203
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1202
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1202
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1203
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1196
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1196
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1196
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1201
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1196
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1196
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1199
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/33
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/33
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/33
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nrc@2df3a5b
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nick29581/rust/impl = 2df3a5b into auto
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nick29581/rust/impl = 2df3a5b merged ok, testing candidate = 6eabd85
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1214
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1213
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1213
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1214
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1207
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1207
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1207
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1212
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1207
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1207
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1210
success: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/44
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/44
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/44
2df3a5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 6eabd85