Skip to content

Commit

Permalink
Auto-upgrade data layouts for X86 address spaces
Browse files Browse the repository at this point in the history
This is similar to the autoupdate LLVM performs internally.
  • Loading branch information
nikic committed Jan 7, 2020
1 parent c3ab84b commit 31aeccc
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions src/librustc_codegen_llvm/context.rs
Expand Up @@ -143,6 +143,22 @@ fn strip_function_ptr_alignment(data_layout: String) -> String {
data_layout.replace("-Fi8-", "-")
}

fn strip_x86_address_spaces(data_layout: String) -> String {
data_layout.replace("-p270:32:32-p271:32:32-p272:64:64-", "-")
}

fn add_x86_address_spaces(mut data_layout: String) -> String {
let address_spaces = "-p270:32:32-p271:32:32-p272:64:64";
if !data_layout.contains(address_spaces) && data_layout.starts_with("e-m:") {
let mut insert_pos = "e-m:?".len();
if data_layout[insert_pos..].starts_with("-p:32:32") {
insert_pos += "-p:32:32".len();
}
data_layout.insert_str(insert_pos, address_spaces);
}
data_layout
}

pub unsafe fn create_module(
tcx: TyCtxt<'_>,
llcx: &'ll llvm::Context,
Expand All @@ -156,6 +172,13 @@ pub unsafe fn create_module(
if llvm_util::get_major_version() < 9 {
target_data_layout = strip_function_ptr_alignment(target_data_layout);
}
if sess.target.target.arch == "x86" || sess.target.target.arch == "x86_64" {
if llvm_util::get_major_version() < 10 {
target_data_layout = strip_x86_address_spaces(target_data_layout);
} else {
target_data_layout = add_x86_address_spaces(target_data_layout);
}
}

// Ensure the data-layout values hardcoded remain the defaults.
if sess.target.target.options.is_builtin {
Expand Down

0 comments on commit 31aeccc

Please sign in to comment.