Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RegionFolder should only invoke callback on free regions.
In other words, Late-bound regions that occur non-free should be skipped. Fix #10846.
- Loading branch information
Showing
1 changed file
with
51 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from nikomatsakis
at pnkfelix@36caa7a
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/fsk-fix-issue-10846 = 36caa7a into auto
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/fsk-fix-issue-10846 = 36caa7a merged ok, testing candidate = f463bbfc
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://54.241.248.193/builders/auto-linux-64-nopt-c/builds/8
exception: http://54.241.248.193/builders/auto-mac-32-opt/builds/4
exception: http://54.241.248.193/builders/auto-linux-32-opt/builds/7
exception: http://54.241.248.193/builders/auto-linux-32-nopt-t/builds/7
exception: http://54.241.248.193/builders/auto-linux-64-x-android-t/builds/10
exception: http://54.241.248.193/builders/auto-win-32-nopt-t/builds/7
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from nikomatsakis
at pnkfelix@36caa7a
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/fsk-fix-issue-10846 = 36caa7a into auto
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/fsk-fix-issue-10846 = 36caa7a merged ok, testing candidate = 43903898
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://54.241.248.193/builders/auto-linux-64-nopt-c/builds/11
exception: http://54.241.248.193/builders/auto-linux-32-opt/builds/10
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcrichton hey if you could email me hints on how you would diagnose this (which seems like build sys issue) I would appreciate it
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you been able to reproduce the failure locally? It looks like it's only failing for an unoptimized compiler, which I often forget to when when attempting to reproduce.
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh super interesting, I did not notice that detail. I will try to reproduce locally.
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from nikomatsakis
at pnkfelix@36caa7a
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/fsk-fix-issue-10846 = 36caa7a into auto
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/fsk-fix-issue-10846 = 36caa7a merged ok, testing candidate = c6f86e4
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://54.241.248.193/builders/auto-mac-32-opt/builds/14
success: http://54.241.248.193/builders/auto-mac-64-opt/builds/14
success: http://54.241.248.193/builders/auto-mac-64-nopt-c/builds/14
success: http://54.241.248.193/builders/auto-mac-64-nopt-t/builds/14
success: http://54.241.248.193/builders/auto-linux-32-opt/builds/17
success: http://54.241.248.193/builders/auto-linux-32-nopt-c/builds/18
success: http://54.241.248.193/builders/auto-linux-32-nopt-t/builds/17
success: http://54.241.248.193/builders/auto-linux-64-opt/builds/23
success: http://54.241.248.193/builders/auto-linux-64-nopt-c/builds/18
success: http://54.241.248.193/builders/auto-linux-64-nopt-t/builds/17
success: http://54.241.248.193/builders/auto-linux-64-x-android-t/builds/20
success: http://54.241.248.193/builders/auto-win-32-opt/builds/18
success: http://54.241.248.193/builders/auto-win-32-nopt-t/builds/17
36caa7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = c6f86e4