Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Augment the constrainted parameter check to ensure that all regions
which get mentioned in an associated type are constrained. Arguably we should just require that all regions are constrained, but that is more of a breaking change.
- Loading branch information
1 parent
ad3cbac
commit 39b7928
Showing
3 changed files
with
127 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// Test that lifetime parameters must be constrained if they appear in | ||
// an associated type def'n. Issue #22077. | ||
|
||
trait Fun { | ||
type Output; | ||
fn call<'x>(&'x self) -> Self::Output; | ||
} | ||
|
||
struct Holder { x: String } | ||
|
||
impl<'a> Fun for Holder { //~ ERROR E0207 | ||
type Output = &'a str; | ||
fn call<'b>(&'b self) -> &'b str { | ||
&self.x[..] | ||
} | ||
} | ||
|
||
fn main() { } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// Regression test for #22886. | ||
|
||
fn crash_please() { | ||
let mut iter = Newtype(Some(Box::new(0))); | ||
let saved = iter.next().unwrap(); | ||
println!("{}", saved); | ||
iter.0 = None; | ||
println!("{}", saved); | ||
} | ||
|
||
struct Newtype(Option<Box<usize>>); | ||
|
||
impl<'a> Iterator for Newtype { //~ ERROR E0207 | ||
type Item = &'a Box<usize>; | ||
|
||
fn next(&mut self) -> Option<&Box<usize>> { | ||
self.0.as_ref() | ||
} | ||
} | ||
|
||
fn main() { } |