Skip to content

Commit

Permalink
Escape stringified expression
Browse files Browse the repository at this point in the history
Payload of `Literal` token must be escaped.
Also print printable non-ASCII characters.
  • Loading branch information
sinkuu committed Mar 14, 2018
1 parent cb5be1b commit 4a254c0
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 5 deletions.
68 changes: 63 additions & 5 deletions src/libsyntax_ext/assert.rs
Expand Up @@ -15,7 +15,7 @@ use syntax::ext::build::AstBuilder;
use syntax::parse::token;
use syntax::print::pprust;
use syntax::tokenstream::{TokenStream, TokenTree};
use syntax_pos::Span;
use syntax_pos::{Span, DUMMY_SP};

pub fn expand_assert<'cx>(
cx: &'cx mut ExtCtxt,
Expand All @@ -41,10 +41,18 @@ pub fn expand_assert<'cx>(
tts: if let Some(ts) = custom_msg_args {
ts.into()
} else {
let panic_str = format!("assertion failed: {}", pprust::expr_to_string(&cond_expr));
TokenStream::from(token::Literal(
token::Lit::Str_(Name::intern(&panic_str)),
None,
// `expr_to_string` escapes the string literals with `.escape_default()`
// which escapes all non-ASCII characters with `\u`.
let escaped_expr = escape_format_string(&unescape_printable_unicode(
&pprust::expr_to_string(&cond_expr),
));

TokenStream::from(TokenTree::Token(
DUMMY_SP,
token::Literal(
token::Lit::Str_(Name::intern(&format!("assertion failed: {}", escaped_expr))),
None,
),
)).into()
},
};
Expand All @@ -62,3 +70,53 @@ pub fn expand_assert<'cx>(
);
MacEager::expr(if_expr)
}

/// Escapes a string for use as a formatting string.
fn escape_format_string(s: &str) -> String {
let mut res = String::with_capacity(s.len());
for c in s.chars() {
res.extend(c.escape_debug());
match c {
'{' | '}' => res.push(c),
_ => {}
}
}
res
}

#[test]
fn test_escape_format_string() {
assert!(escape_format_string(r"foo{}\") == r"foo{{}}\\");
}

/// Unescapes the escaped unicodes (`\u{...}`) that are printable.
fn unescape_printable_unicode(mut s: &str) -> String {
use std::{char, u32};

let mut res = String::with_capacity(s.len());

loop {
if let Some(start) = s.find(r"\u{") {
res.push_str(&s[0..start]);
s = &s[start..];
s.find('}')
.and_then(|end| {
let v = u32::from_str_radix(&s[3..end], 16).ok()?;
let c = char::from_u32(v)?;
// Escape unprintable characters.
res.extend(c.escape_debug());
s = &s[end + 1..];
Some(())
})
.expect("lexer should have rejected invalid escape sequences");
} else {
res.push_str(s);
return res;
}
}
}

#[test]
fn test_unescape_printable_unicode() {
assert!(unescape_printable_unicode(r"\u{2603}\n\u{0}") == r"☃\n\u{0}");
}
1 change: 1 addition & 0 deletions src/libsyntax_ext/lib.rs
Expand Up @@ -17,6 +17,7 @@

#![feature(proc_macro_internals)]
#![feature(decl_macro)]
#![feature(str_escape)]

extern crate fmt_macros;
#[macro_use]
Expand Down
13 changes: 13 additions & 0 deletions src/test/run-pass/assert-escape.rs
@@ -0,0 +1,13 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {
assert!(r#"☃\backslash"#.contains("\\"));
}

0 comments on commit 4a254c0

Please sign in to comment.