Skip to content

Commit

Permalink
Rename pkgid variables
Browse files Browse the repository at this point in the history
  • Loading branch information
luisbg committed Dec 29, 2013
1 parent aa5d779 commit 4bc0971
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion src/librustc/back/link.rs
Expand Up @@ -475,7 +475,7 @@ pub fn build_link_meta(sess: Session,
truncated_hash_result(symbol_hasher).to_managed()
}

let pkgid = match attr::find_pkgid(attrs) {
let crateid = match attr::find_crateid(attrs) {
None => {
let stem = session::expect(
sess,
Expand Down
10 changes: 5 additions & 5 deletions src/librustc/driver/driver.rs
Expand Up @@ -1030,12 +1030,12 @@ pub fn build_output_filenames(input: &input,
str_input(_) => @"rust_out"
};

// If a pkgid is present, we use it as the link name
let pkgid = attr::find_pkgid(attrs);
match pkgid {
// If a crateid is present, we use it as the link name
let crateid = attr::find_crateid(attrs);
match crateid {
None => {}
Some(pkgid) => {
stem = pkgid.name.to_managed()
Some(crateid) => {
stem = crateid.name.to_managed()
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/librustc/front/test.rs
Expand Up @@ -385,7 +385,7 @@ fn mk_tests(cx: &TestCtxt) -> @ast::item {
}

fn is_extra(crate: &ast::Crate) -> bool {
match attr::find_pkgid(crate.attrs) {
match attr::find_crateid(crate.attrs) {
Some(ref s) if "extra" == s.name => true,
_ => false
}
Expand Down
8 changes: 4 additions & 4 deletions src/librustc/lib.rs
Expand Up @@ -292,18 +292,18 @@ pub fn run_compiler(args: &[~str], demitter: @diagnostic::Emitter) {
let t_outputs = d::build_output_filenames(&input, &odir, &ofile,
attrs, sess);
if crate_id || crate_name {
let pkgid = match attr::find_pkgid(attrs) {
Some(pkgid) => pkgid,
let crateid = match attr::find_crateid(attrs) {
Some(crateid) => crateid,
None => {
sess.fatal("No crate_id and --crate-id or \
--crate-name requested")
}
};
if crate_id {
println(pkgid.to_str());
println(crateid.to_str());
}
if crate_name {
println(pkgid.name);
println(crateid.name);
}
}

Expand Down
12 changes: 6 additions & 6 deletions src/librustc/metadata/creader.rs
Expand Up @@ -138,15 +138,15 @@ fn visit_view_item(e: &mut Env, i: &ast::view_item) {
ident, path_opt);
let (name, version) = match path_opt {
Some((path_str, _)) => {
let pkgid: Option<PkgId> = from_str(path_str);
match pkgid {
let crateid: Option<PkgId> = from_str(path_str);
match crateid {
None => (@"", @""),
Some(pkgid) => {
let version = match pkgid.version {
Some(crateid) => {
let version = match crateid.version {
None => @"",
Some(ref ver) => ver.to_managed(),
};
(pkgid.name.to_managed(), version)
(crateid.name.to_managed(), version)
}
}
}
Expand Down Expand Up @@ -282,7 +282,7 @@ fn resolve_crate(e: &mut Env,
} = load_ctxt.load_library_crate();

let attrs = decoder::get_crate_attributes(metadata.as_slice());
let pkgid = attr::find_pkgid(attrs).unwrap();
let crateid = attr::find_crateid(attrs).unwrap();
let hash = decoder::get_crate_hash(metadata.as_slice());

// Claim this crate number and cache it
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/metadata/decoder.rs
Expand Up @@ -1173,7 +1173,7 @@ pub fn get_crate_hash(data: &[u8]) -> @str {

pub fn get_crate_vers(data: &[u8]) -> @str {
let attrs = decoder::get_crate_attributes(data);
match attr::find_pkgid(attrs) {
match attr::find_crateid(attrs) {
None => @"0.0",
Some(pkgid) => pkgid.version_or_default().to_managed(),
}
Expand Down
4 changes: 2 additions & 2 deletions src/librustc/metadata/loader.rs
Expand Up @@ -165,7 +165,7 @@ impl Context {
}
let data = lib.metadata.as_slice();
let attrs = decoder::get_crate_attributes(data);
match attr::find_pkgid(attrs) {
match attr::find_crateid(attrs) {
None => {}
Some(pkgid) => {
note_pkgid_attr(self.sess.diagnostic(), &pkgid);
Expand Down Expand Up @@ -241,7 +241,7 @@ fn crate_matches(crate_data: &[u8],
version: @str,
hash: @str) -> bool {
let attrs = decoder::get_crate_attributes(crate_data);
match attr::find_pkgid(attrs) {
match attr::find_crateid(attrs) {
None => false,
Some(pkgid) => {
if !hash.is_empty() {
Expand Down
4 changes: 2 additions & 2 deletions src/librustdoc/clean.rs
Expand Up @@ -73,7 +73,7 @@ pub struct Crate {

impl Clean<Crate> for visit_ast::RustdocVisitor {
fn clean(&self) -> Crate {
use syntax::attr::find_pkgid;
use syntax::attr::find_crateid;
let cx = local_data::get(super::ctxtkey, |x| *x.unwrap());

let mut externs = HashMap::new();
Expand All @@ -82,7 +82,7 @@ impl Clean<Crate> for visit_ast::RustdocVisitor {
});

Crate {
name: match find_pkgid(self.attrs) {
name: match find_crateid(self.attrs) {
Some(n) => n.name,
None => fail!("rustdoc requires a `crate_id` crate attribute"),
},
Expand Down
4 changes: 2 additions & 2 deletions src/libsyntax/attr.rs
Expand Up @@ -234,10 +234,10 @@ pub fn find_linkage_metas(attrs: &[Attribute]) -> ~[@MetaItem] {
result
}

pub fn find_pkgid(attrs: &[Attribute]) -> Option<PkgId> {
pub fn find_crateid(attrs: &[Attribute]) -> Option<CrateId> {
match first_attr_value_str_by_name(attrs, "crate_id") {
None => None,
Some(id) => from_str::<PkgId>(id),
Some(id) => from_str::<CrateId>(id),
}
}

Expand Down

0 comments on commit 4bc0971

Please sign in to comment.