Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Fix the tcp-accept-stress test
It was previously asserted that each thread received at least one connection, but this is not guaranteed to always be the case due to scheduling. This test also deadlocked on failure due to a lingering reference to the sending half of the channel, so that reference is now also eagerly dropped so the test can fail properly if something bad happens. Closes #16872
- Loading branch information
4ddbb0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at alexcrichton@4ddbb0d
4ddbb0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/issue-16872 = 4ddbb0d into auto
4ddbb0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/issue-16872 = 4ddbb0d merged ok, testing candidate = 08176a3
4ddbb0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1100
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1100
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1099
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1100
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1095
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1096
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1095
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1101
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1096
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1095
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1098
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1099
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1097
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1098
4ddbb0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 08176a3