Navigation Menu

Skip to content

Commit

Permalink
Use new const-checker for mir_const_qualif
Browse files Browse the repository at this point in the history
Now `mir_const_qualif` must be called for `static`s and `const fn`s as
well as `const`s since it is responsible for const-checking. We return
the qualifs in the return place for everything, even though they will
only be used for `const`s.
  • Loading branch information
ecstatic-morse committed Nov 15, 2019
1 parent 973b16a commit 55da0c0
Showing 1 changed file with 37 additions and 2 deletions.
39 changes: 37 additions & 2 deletions src/librustc_mir/transform/mod.rs
Expand Up @@ -2,7 +2,7 @@ use crate::{build, shim};
use rustc_index::vec::IndexVec;
use rustc::hir::def_id::{CrateNum, DefId, LOCAL_CRATE};
use rustc::mir::{Body, MirPhase, Promoted};
use rustc::ty::{TyCtxt, InstanceDef};
use rustc::ty::{TyCtxt, InstanceDef, TypeFoldable};
use rustc::ty::query::Providers;
use rustc::ty::steal::Steal;
use rustc::hir;
Expand Down Expand Up @@ -39,12 +39,12 @@ pub mod uniform_array_move_out;
pub mod uninhabited_enum_branching;

pub(crate) fn provide(providers: &mut Providers<'_>) {
self::qualify_consts::provide(providers);
self::check_unsafety::provide(providers);
*providers = Providers {
mir_keys,
mir_built,
mir_const,
mir_const_qualif,
mir_validated,
optimized_mir,
is_mir_available,
Expand Down Expand Up @@ -185,6 +185,41 @@ pub fn run_passes(
body.phase = mir_phase;
}

fn mir_const_qualif(tcx: TyCtxt<'_>, def_id: DefId) -> u8 {
let const_kind = check_consts::ConstKind::for_item(tcx, def_id);

// No need to const-check a non-const `fn`.
if const_kind.is_none() {
return 0;
}

// N.B., this `borrow()` is guaranteed to be valid (i.e., the value
// cannot yet be stolen), because `mir_validated()`, which steals
// from `mir_const(), forces this query to execute before
// performing the steal.
let body = &tcx.mir_const(def_id).borrow();

if body.return_ty().references_error() {
tcx.sess.delay_span_bug(body.span, "mir_const_qualif: MIR had errors");
return 0;
}

let item = check_consts::Item {
body,
tcx,
def_id,
const_kind,
param_env: tcx.param_env(def_id),
};

let mut validator = check_consts::validation::Validator::new(&item);
validator.check_body();

// We return the qualifs in the return place for every MIR body, even though it is only used
// when deciding to promote a reference to a `const` for now.
validator.qualifs_in_return_place().into()
}

fn mir_const(tcx: TyCtxt<'_>, def_id: DefId) -> &Steal<Body<'_>> {
// Unsafety check uses the raw mir, so make sure it is run
let _ = tcx.unsafety_check_result(def_id);
Expand Down

0 comments on commit 55da0c0

Please sign in to comment.