Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
c_str: move
.unwrap
& document it more clearly.
This should be called rarely, but it was placed first in the list of methods, making it very tempting to call.
- Loading branch information
Showing
1 changed file
with
16 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
569f13a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at huonw@569f13a
569f13a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging huonw/rust/cstr-remove-withref = 569f13a into auto
569f13a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huonw/rust/cstr-remove-withref = 569f13a merged ok, testing candidate = b569c77
569f13a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/97
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/98
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/98
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/98
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/101
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/102
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/101
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/107
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/102
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/101
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/104
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/102
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/101
569f13a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = b569c77