Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libcore: Fix
Sized
bounds on overloaded function traits.
- Remove the `for Sized?` bound on `core::ops::FnOnce`, as it takes `self` by value and can never be implemented by an unsized type. - Add a missing `Sized?` bound to the blanket `core::ops::FnMut` impl, as both `Fn` and `FnMut` are `for Sized?`.
- Loading branch information
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/apasel422/rust/commit/600faba5bc0b0b8bfef048ca9e8698e5f8c157f0
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging apasel422/rust/sized_fn_once = 600faba into auto
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apasel422/rust/sized_fn_once = 600faba merged ok, testing candidate = 25aa8523
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2621
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2621
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2276
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1113
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1107
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/1103
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/apasel422/rust/commit/600faba5bc0b0b8bfef048ca9e8698e5f8c157f0
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging apasel422/rust/sized_fn_once = 600faba into auto
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apasel422/rust/sized_fn_once = 600faba merged ok, testing candidate = 4c692d3
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2635
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2631
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2623
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2631
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2622
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2620
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2621
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2625
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2617
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2617
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2617
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2284
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2281
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2286
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1123
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1117
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/1113
600faba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 4c692d3