Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove the double auto-ref on arrays/strings as receivers
Part of #18469 [breaking-change] A receiver will only ever get a single auto-reference. Previously arrays and strings would get two, e.g., [T] would be auto-ref'ed to &&[T]. This is usually apparent when a trait is implemented for `&[T]` and has a method takes self by reference. The usual solution is to implement the trait for `[T]` (the DST form).
- Loading branch information
Showing
6 changed files
with
22 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
769aa0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from nikomatsakis
at nrc@769aa0a
769aa0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nick29581/rust/coerce-double = 769aa0a into auto
769aa0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: {"merge_sha": "4265e86844b6f328ed8a0d144d02a935706c35ee"}
769aa0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nick29581/rust/coerce-double = 769aa0a merged ok, testing candidate = 4265e86
769aa0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2721
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2716
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2717
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2708
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2707
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2711
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2703
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2703
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2368
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2365
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1207
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1201
769aa0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 4265e86
769aa0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 4265e86