Skip to content

Commit

Permalink
More upstream lint changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Keegan McAllister committed Jun 24, 2014
1 parent 7dc724b commit 7e694e7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 27 deletions.
32 changes: 6 additions & 26 deletions src/librustc/lint/builtin.rs
Expand Up @@ -1358,7 +1358,8 @@ impl LintPass for MissingDoc {
declare_lint!(DEPRECATED, Warn,
"detects use of #[deprecated] items")

declare_lint!(EXPERIMENTAL, Warn,
// FIXME #6875: Change to Warn after std library stabilization is complete
declare_lint!(EXPERIMENTAL, Allow,
"detects use of #[experimental] items")

declare_lint!(UNSTABLE, Allow,
Expand Down Expand Up @@ -1411,32 +1412,11 @@ impl LintPass for Stability {
_ => return
};

let stability = if ast_util::is_local(id) {
// this crate
let s = cx.tcx.map.with_attrs(id.node, |attrs| {
attrs.map(|a| attr::find_stability(a.as_slice()))
});
match s {
Some(s) => s,
// stability attributes are promises made across crates; do not
// check anything for crate-local usage.
if ast_util::is_local(id) { return }

// no possibility of having attributes
// (e.g. it's a local variable), so just
// ignore it.
None => return
}
} else {
// cross-crate

let mut s = None;
// run through all the attributes and take the first
// stability one.
csearch::get_item_attrs(&cx.sess().cstore, id, |attrs| {
if s.is_none() {
s = attr::find_stability(attrs.as_slice())
}
});
s
};
let stability = cx.tcx.stability.borrow_mut().lookup(&cx.tcx.sess.cstore, id);

let (lint, label) = match stability {
// no stability attributes == Unstable
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/lint/context.rs
Expand Up @@ -411,7 +411,7 @@ impl<'a> Context<'a> {
impl<'a> AstConv for Context<'a>{
fn tcx<'a>(&'a self) -> &'a ty::ctxt { self.tcx }

fn get_item_ty(&self, id: ast::DefId) -> ty::ty_param_bounds_and_ty {
fn get_item_ty(&self, id: ast::DefId) -> ty::Polytype {
ty::lookup_item_type(self.tcx, id)
}

Expand Down

5 comments on commit 7e694e7

@bors
Copy link
Contributor

@bors bors commented on 7e694e7 Jun 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at kmcallister@7e694e7

@bors
Copy link
Contributor

@bors bors commented on 7e694e7 Jun 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging kmcallister/rust/lint = 7e694e7 into auto

@bors
Copy link
Contributor

@bors bors commented on 7e694e7 Jun 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kmcallister/rust/lint = 7e694e7 merged ok, testing candidate = 05ca9f7

@bors
Copy link
Contributor

@bors bors commented on 7e694e7 Jun 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 05ca9f7

Please sign in to comment.