Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Initialize memory for BufferedReader buffer
It's passed to the underlying reader, so uninitialized memory == sad times. We might want to shrink the default buffer size as well. 64k is pretty huge. Java uses 8k by default, and Go uses 4k for reference.
- Loading branch information
Showing
1 changed file
with
10 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89f1848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from Gankro
at sfackler@89f1848
89f1848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging sfackler/rust/bufferedreader-undef = 89f1848 into auto
89f1848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: {"merge_sha": "d52398ef8cd93c6089ceacb176ae0dbe213d301e"}
89f1848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sfackler/rust/bufferedreader-undef = 89f1848 merged ok, testing candidate = d52398e
89f1848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3139
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3132
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3133
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3124
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3124
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3127
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3120
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3115
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2792
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2790
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1628
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1621
89f1848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = d52398e
89f1848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = d52398e