Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix type checking of struct fields in patterns of type ty_err
- Loading branch information
Jakub Wieczorek
committed
Aug 17, 2014
1 parent
a12a4dd
commit 9b0f89d
Showing
3 changed files
with
43 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use std::raw::Slice; | ||
|
||
fn main() { | ||
let Slice { data: data, len: len } = "foo"; | ||
//~^ ERROR mismatched types: expected `&'static str` but found a structure pattern | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use std::raw::Slice; | ||
|
||
fn main() { | ||
match () { | ||
Slice { data: data, len: len } => (), | ||
//~^ ERROR mismatched types: expected `()` but found a structure pattern | ||
_ => unreachable!() | ||
} | ||
} |
9b0f89d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at https://github.com/jakub-/rust/commit/9b0f89d342de06b035c108186f0243a3bdc7528b
9b0f89d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging jakub-/rust/struct-pat-fields-ty-err = 9b0f89d into auto
9b0f89d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jakub-/rust/struct-pat-fields-ty-err = 9b0f89d merged ok, testing candidate = 776c17f
9b0f89d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/888
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/888
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/887
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/888
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/883
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/884
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/883
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/889
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/884
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/883
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/886
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/884
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/884
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/885
9b0f89d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 776c17f