Skip to content

Commit

Permalink
Fix generating rustc docs with non-default lib directory.
Browse files Browse the repository at this point in the history
  • Loading branch information
ehuss committed Sep 14, 2020
1 parent 32efcfc commit 9dad908
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
8 changes: 6 additions & 2 deletions src/bootstrap/builder.rs
Expand Up @@ -710,15 +710,15 @@ impl<'a> Builder<'a> {

/// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
/// library lookup path.
pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Cargo) {
pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
// Windows doesn't need dylib path munging because the dlls for the
// compiler live next to the compiler and the system will find them
// automatically.
if cfg!(windows) {
return;
}

add_dylib_path(vec![self.rustc_libdir(compiler)], &mut cmd.command);
add_dylib_path(vec![self.rustc_libdir(compiler)], cmd);
}

/// Gets a path to the compiler specified.
Expand Down Expand Up @@ -1515,6 +1515,10 @@ impl Cargo {
self.command.env(key.as_ref(), value.as_ref());
self
}

pub fn add_rustc_lib_path(&mut self, builder: &Builder<'_>, compiler: Compiler) {
builder.add_rustc_lib_path(compiler, &mut self.command);
}
}

impl From<Cargo> for Command {
Expand Down
4 changes: 4 additions & 0 deletions src/bootstrap/doc.rs
Expand Up @@ -766,6 +766,10 @@ impl Step for RustcBook {
if builder.config.verbose() {
cmd.arg("--verbose");
}
// If the lib directories are in an unusual location (changed in
// config.toml), then this needs to explicitly update the dylib search
// path.
builder.add_rustc_lib_path(self.compiler, &mut cmd);
builder.run(&mut cmd);
// Run rustbook/mdbook to generate the HTML pages.
builder.ensure(RustbookSrc {
Expand Down
8 changes: 4 additions & 4 deletions src/bootstrap/test.rs
Expand Up @@ -270,7 +270,7 @@ impl Step for Rls {
&[],
);

builder.add_rustc_lib_path(compiler, &mut cargo);
cargo.add_rustc_lib_path(builder, compiler);
cargo.arg("--").args(builder.config.cmd.test_args());

if try_run(builder, &mut cargo.into()) {
Expand Down Expand Up @@ -328,7 +328,7 @@ impl Step for Rustfmt {
t!(fs::create_dir_all(&dir));
cargo.env("RUSTFMT_TEST_DIR", dir);

builder.add_rustc_lib_path(compiler, &mut cargo);
cargo.add_rustc_lib_path(builder, compiler);

if try_run(builder, &mut cargo.into()) {
builder.save_toolstate("rustfmt", ToolState::TestPass);
Expand Down Expand Up @@ -449,7 +449,7 @@ impl Step for Miri {

cargo.arg("--").args(builder.config.cmd.test_args());

builder.add_rustc_lib_path(compiler, &mut cargo);
cargo.add_rustc_lib_path(builder, compiler);

if !try_run(builder, &mut cargo.into()) {
return;
Expand Down Expand Up @@ -554,7 +554,7 @@ impl Step for Clippy {

cargo.arg("--").args(builder.config.cmd.test_args());

builder.add_rustc_lib_path(compiler, &mut cargo);
cargo.add_rustc_lib_path(builder, compiler);

builder.run(&mut cargo.into());
}
Expand Down

0 comments on commit 9dad908

Please sign in to comment.