Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
converted TODOs into XXXs
  • Loading branch information
Eric Reed committed Jul 3, 2013
1 parent 6a1a781 commit b60cf0c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
1 change: 0 additions & 1 deletion src/libstd/rt/rtio.rs
Expand Up @@ -23,7 +23,6 @@ pub type IoFactoryObject = uvio::UvIoFactory;
pub type RtioTcpStreamObject = uvio::UvTcpStream;
pub type RtioTcpListenerObject = uvio::UvTcpListener;
pub type RtioUdpSocketObject = uvio::UvUdpSocket;
pub type RtioTcpSocketObject = (); // TODO

pub trait EventLoop {
fn run(&mut self);
Expand Down
14 changes: 7 additions & 7 deletions src/libstd/rt/uv/uvio.rs
Expand Up @@ -316,7 +316,7 @@ impl Drop for UvTcpListener {
}

impl RtioSocket for UvTcpListener {
// TODO
// XXX implement
fn socket_name(&self) -> IpAddr { fail!(); }
}

Expand Down Expand Up @@ -356,7 +356,7 @@ impl RtioTcpListener for UvTcpListener {
return self.incoming_streams.recv();
}

// TODO
// XXX implement
fn accept_simultaneously(&self) { fail!(); }
fn dont_accept_simultaneously(&self) { fail!(); }
}
Expand All @@ -379,7 +379,7 @@ impl Drop for UvTcpStream {
}

impl RtioSocket for UvTcpStream {
// TODO
// XXX implement
fn socket_name(&self) -> IpAddr { fail!(); }
}

Expand Down Expand Up @@ -455,7 +455,7 @@ impl RtioTcpStream for UvTcpStream {
return result_cell.take();
}

// TODO
// XXX implement
fn peer_name(&self) -> IpAddr { fail!(); }
fn control_congestion(&self) { fail!(); }
fn nodelay(&self) { fail!(); }
Expand All @@ -480,7 +480,7 @@ impl Drop for UvUdpSocket {
}

impl RtioSocket for UvUdpSocket {
// TODO
// XXX implement
fn socket_name(&self) -> IpAddr { fail!(); }
}

Expand All @@ -498,7 +498,7 @@ impl RtioUdpSocket for UvUdpSocket {
let task_cell = Cell::new(task);
let alloc: AllocCallback = |_| unsafe { slice_to_uv_buf(*buf_ptr) };
do self.recv_start(alloc) |watcher, nread, _buf, addr, flags, status| {
let _ = flags; // TODO add handling for partials?
let _ = flags; // XXX add handling for partials?

watcher.recv_stop();

Expand Down Expand Up @@ -548,7 +548,7 @@ impl RtioUdpSocket for UvUdpSocket {
return result_cell.take();
}

// TODO
// XXX implement
fn join_multicast(&self, _multi: IpAddr) { fail!(); }
fn leave_multicast(&self, _multi: IpAddr) { fail!(); }

Expand Down

0 comments on commit b60cf0c

Please sign in to comment.