Remove casts from FullInt impl

rust-lang · Oct 30, 2021 · c8edd9a · c8edd9a
1 parent 665ff57
commit c8edd9a
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/clippy_utils/src/consts.rs b/clippy_utils/src/consts.rs
@@ -230,16 +230,9 @@ pub enum FullInt {
 }
 
 impl FullInt {
-    #[allow(clippy::cast_sign_loss)]
     #[must_use]
     fn cmp_s_u(s: i128, u: u128) -> Ordering {
-        if s < 0 {
-            Ordering::Less
-        } else if u > (i128::MAX as u128) {
-            Ordering::Greater
-        } else {
-            (s as u128).cmp(&u)
-        }
+        u128::try_from(s).map_or(Ordering::Less, |x| x.cmp(&u))
     }
 }