Skip to content

Commit

Permalink
Added a FIXME with issue number to change package_id
Browse files Browse the repository at this point in the history
  • Loading branch information
tautologico committed Nov 8, 2013
1 parent 455de85 commit ca22e94
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc/metadata/encoder.rs
Expand Up @@ -1510,7 +1510,7 @@ fn synthesize_crate_attrs(ecx: &EncodeContext,
pkg_id),
// uses package_id equal to name;
// this should never happen here but package_id is an Option
// FIX: change package_id in LinkMeta to @str instead of Option<@str>
// FIXME (#10370): change package_id in LinkMeta to @str instead of Option<@str>
_ => attr::mk_name_value_item_str(@"package_id",
ecx.link_meta.name)
};
Expand Down

9 comments on commit ca22e94

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 8, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 8, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging tautologico/rust/default_pkgid = ca22e94 into auto

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 8, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tautologico/rust/default_pkgid = ca22e94 merged ok, testing candidate = b5eda9ec

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 8, 2013

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging tautologico/rust/default_pkgid = ca22e94 into auto

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tautologico/rust/default_pkgid = ca22e94 merged ok, testing candidate = 4f68d13

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on ca22e94 Nov 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 4f68d13

Please sign in to comment.