Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean up the implementations of Bitv and BitvSet.
Functions that add bits now ensure that any unused bits are set to 0. `into_bitv` sanitizes the nbits of the Bitv/BitvSet it returns by setting the nbits to the current capacity. Fix a bug with `union_with` and `symmetric_difference` with due to not updating nbits properly Add test cases to the _with functions Remove `get_mut_ref` This is a [breaking-change]. The things you will need to fix are: 1. BitvSet's `unwrap()` has been renamed to `into_bitv` 2. BitvSet's `get_mut_ref()` has been removed. Use `into_bitv()` and `from_bitv()` instead.
- Loading branch information
Showing
1 changed file
with
131 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd4fa90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from aturon
at https://github.com/kaseyc/rust/commit/dd4fa906fcc3f21eca8d8ce958b4728ed62581e1
dd4fa90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging kaseyc/rust/fix_bitvset_union = dd4fa90 into auto
dd4fa90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kaseyc/rust/fix_bitvset_union = dd4fa90 merged ok, testing candidate = 79d056f
dd4fa90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1729
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1726
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1720
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1726
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1723
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1722
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1722
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1726
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1720
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1719
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1722
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1380
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1376
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1380
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/213
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/213
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/211
dd4fa90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 79d056f