Navigation Menu

Skip to content

Commit

Permalink
Remove seldom-used std::reference functions.
Browse files Browse the repository at this point in the history
  • Loading branch information
xales committed Jan 30, 2014
1 parent d547f7a commit f17d972
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 39 deletions.
5 changes: 2 additions & 3 deletions src/libextra/arc.rs
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down Expand Up @@ -47,7 +47,6 @@ use sync::{Mutex, RWLock};
use std::cast;
use std::sync::arc::UnsafeArc;
use std::task;
use std::reference;

/// As sync::condvar, a mechanism for unlock-and-descheduling and signaling.
pub struct Condvar<'a> {
Expand Down Expand Up @@ -465,7 +464,7 @@ impl<T:Freeze + Send> RWArc<T> {
// of this cast is removing the mutability.)
let new_data = data;
// Downgrade ensured the token belonged to us. Just a sanity check.
assert!(reference::ref_eq(&(*state).data, new_data));
assert!((&(*state).data as *T as uint) == (new_data as *mut T as uint));
// Produce new token
RWReadMode {
data: new_data,
Expand Down
5 changes: 2 additions & 3 deletions src/libextra/sync.rs
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -18,7 +18,6 @@
*/


use std::reference;
use std::comm;
use std::unstable::sync::Exclusive;
use std::sync::arc::UnsafeArc;
Expand Down Expand Up @@ -634,7 +633,7 @@ impl RWLock {
/// To be called inside of the write_downgrade block.
pub fn downgrade<'a>(&self, token: RWLockWriteMode<'a>)
-> RWLockReadMode<'a> {
if !reference::ref_eq(self, token.lock) {
if !((self as *RWLock) == (token.lock as *RWLock)) {
fail!("Can't downgrade() with a different rwlock's write_mode!");
}
unsafe {
Expand Down
2 changes: 1 addition & 1 deletion src/libstd/lib.rs
Expand Up @@ -123,7 +123,7 @@ pub mod send_str;
pub mod ptr;
pub mod owned;
pub mod managed;
pub mod reference;
mod reference;
pub mod rc;
pub mod gc;

Expand Down
25 changes: 0 additions & 25 deletions src/libstd/reference.rs
Expand Up @@ -13,18 +13,6 @@
#[cfg(not(test))]
use prelude::*;

/// Cast a region pointer - &T - to a uint.
#[inline]
pub fn to_uint<T>(thing: &T) -> uint {
thing as *T as uint
}

/// Determine if two borrowed pointers point to the same thing.
#[inline]
pub fn ref_eq<'a, 'b, T>(thing: &'a T, other: &'b T) -> bool {
(thing as *T) == (other as *T)
}

// Equality for region pointers
#[cfg(not(test))]
impl<'a, T: Eq> Eq for &'a T {
Expand Down Expand Up @@ -71,16 +59,3 @@ impl<'a, T: TotalEq> TotalEq for &'a T {
fn equals(&self, other: & &'a T) -> bool { (**self).equals(*other) }
}

#[cfg(test)]
mod tests {
use super::ref_eq;

#[test]
fn test_ref_eq() {
let x = 1;
let y = 1;

assert!(ref_eq(&x, &x));
assert!(!ref_eq(&x, &y));
}
}
3 changes: 1 addition & 2 deletions src/libstd/rt/task.rs
Expand Up @@ -14,7 +14,6 @@
//! to implement this.

use any::AnyOwnExt;
use reference;
use cast;
use cleanup;
use clone::Clone;
Expand Down Expand Up @@ -287,7 +286,7 @@ impl Task {

impl Drop for Task {
fn drop(&mut self) {
rtdebug!("called drop for a task: {}", reference::to_uint(self));
rtdebug!("called drop for a task: {}", self as *mut Task as uint);
rtassert!(self.destroyed);
}
}
Expand Down
3 changes: 1 addition & 2 deletions src/test/run-pass/borrowck-borrow-from-expr-block.rs
Expand Up @@ -10,7 +10,6 @@

#[feature(managed_boxes)];

use std::reference;
use std::ptr;

fn borrow(x: &int, f: |x: &int|) {
Expand All @@ -20,7 +19,7 @@ fn borrow(x: &int, f: |x: &int|) {
fn test1(x: @~int) {
borrow(&*(*x).clone(), |p| {
let x_a = ptr::to_unsafe_ptr(&**x);
assert!((x_a as uint) != reference::to_uint(p));
assert!((x_a as uint) != (p as *int as uint));
assert_eq!(unsafe{*x_a}, *p);
})
}
Expand Down
4 changes: 1 addition & 3 deletions src/test/run-pass/cast-region-to-uint.rs
Expand Up @@ -8,9 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

use std::reference;

pub fn main() {
let x = 3;
info!("&x={:x}", reference::to_uint(&x));
info!("&x={:x}", (&x as *int as uint));
}

9 comments on commit f17d972

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at xales@f17d972

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging xales/rust/libstd = f17d972 into auto

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xales/rust/libstd = f17d972 merged ok, testing candidate = ba70bd18

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at xales@f17d972

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging xales/rust/libstd = f17d972 into auto

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xales/rust/libstd = f17d972 merged ok, testing candidate = b3003e1

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on f17d972 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = b3003e1

Please sign in to comment.