Skip to content

Commit

Permalink
Change xfail directives in compiletests to ignore, closes #11363
Browse files Browse the repository at this point in the history
  • Loading branch information
fhahn committed Feb 11, 2014
1 parent 5b5ebf2 commit f62460c
Show file tree
Hide file tree
Showing 539 changed files with 1,154 additions and 1,142 deletions.
2 changes: 1 addition & 1 deletion mk/tests.mk
Expand Up @@ -34,7 +34,7 @@ ifdef TESTNAME
TESTARGS += $(TESTNAME)
endif

ifdef CHECK_XFAILS
ifdef CHECK_IGNORED
TESTARGS += --ignored
endif

Expand Down
2 changes: 1 addition & 1 deletion src/compiletest/compiletest.rs
Expand Up @@ -61,7 +61,7 @@ pub fn parse_config(args: ~[~str]) -> config {
reqopt("", "stage-id", "the target-stage identifier", "stageN-TARGET"),
reqopt("", "mode", "which sort of compile tests to run",
"(compile-fail|run-fail|run-pass|pretty|debug-info)"),
optflag("", "ignored", "run tests marked as ignored / xfailed"),
optflag("", "ignored", "run tests marked as ignored"),
optopt("", "runtool", "supervisor program to run tests under \
(eg. emulator, valgrind)", "PROGRAM"),
optopt("", "rustcflags", "flags to pass to rustc", "FLAGS"),
Expand Down
16 changes: 8 additions & 8 deletions src/compiletest/header.rs
Expand Up @@ -95,19 +95,19 @@ pub fn load_props(testfile: &Path) -> TestProps {
}

pub fn is_test_ignored(config: &config, testfile: &Path) -> bool {
fn xfail_target(config: &config) -> ~str {
~"xfail-" + util::get_os(config.target)
fn ignore_target(config: &config) -> ~str {
~"ignore-" + util::get_os(config.target)
}
fn xfail_stage(config: &config) -> ~str {
~"xfail-" + config.stage_id.split('-').next().unwrap()
fn ignore_stage(config: &config) -> ~str {
~"ignore-" + config.stage_id.split('-').next().unwrap()
}
let val = iter_header(testfile, |ln| {
if parse_name_directive(ln, "xfail-test") { false }
else if parse_name_directive(ln, xfail_target(config)) { false }
else if parse_name_directive(ln, xfail_stage(config)) { false }
if parse_name_directive(ln, "ignore-test") { false }
else if parse_name_directive(ln, ignore_target(config)) { false }
else if parse_name_directive(ln, ignore_stage(config)) { false }
else if config.mode == common::mode_pretty &&
parse_name_directive(ln, "xfail-pretty") { false }
parse_name_directive(ln, "ignore-pretty") { false }
else { true }
});

Expand Down
8 changes: 4 additions & 4 deletions src/etc/combine-tests.py
@@ -1,4 +1,4 @@
# Copyright 2011-2013 The Rust Project Developers. See the COPYRIGHT
# Copyright 2011-2014 The Rust Project Developers. See the COPYRIGHT
# file at the top-level directory of this distribution and at
# http://rust-lang.org/COPYRIGHT.
#
Expand Down Expand Up @@ -36,9 +36,9 @@ def scrub(b):
t.startswith(".") or t.startswith("#") or t.startswith("~")):
f = codecs.open(os.path.join(run_pass, t), "r", "utf8")
s = f.read()
if not ("xfail-test" in s or
"xfail-fast" in s or
"xfail-win32" in s):
if not ("ignore-test" in s or
"ignore-fast" in s or
"ignore-win32" in s):
if not "pub fn main" in s and "fn main" in s:
print("Warning: no public entry point in " + t)
stage2_tests.append(t)
Expand Down
2 changes: 1 addition & 1 deletion src/etc/extract-tests.py
Expand Up @@ -99,7 +99,7 @@ def extract_code_fragments(dest_dir, lines):
block.appendleft(OUTPUT_BLOCK_HEADER)

if "ignore" in tags:
block.appendleft("//xfail-test\n")
block.appendleft("//ignore-test\n")
elif "should_fail" in tags:
block.appendleft("//should-fail\n")

Expand Down
6 changes: 3 additions & 3 deletions src/etc/licenseck.py
@@ -1,4 +1,4 @@
# Copyright 2013 The Rust Project Developers. See the COPYRIGHT
# Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
# file at the top-level directory of this distribution and at
# http://rust-lang.org/COPYRIGHT.
#
Expand Down Expand Up @@ -52,12 +52,12 @@ def check_license(name, contents):

# Xfail check
firstlineish = contents[:100]
if firstlineish.find("xfail-license") != -1:
if firstlineish.find("ignore-license") != -1:
return True

# License check
boilerplate = contents[:500]
if (boilerplate.find(license1) == -1 or boilerplate.find(license2) == -1) and \
(boilerplate.find(license3) == -1 or boilerplate.find(license4) == -1):
return False
return True
return True
6 changes: 3 additions & 3 deletions src/etc/tidy.py
Expand Up @@ -14,9 +14,9 @@

err=0
cols=100
cr_flag="xfail-tidy-cr"
tab_flag="xfail-tidy-tab"
linelength_flag="xfail-tidy-linelength"
cr_flag="ignore-tidy-cr"
tab_flag="ignore-tidy-tab"
linelength_flag="ignore-tidy-linelength"

# Be careful to support Python 2.4, 2.6, and 3.x here!
config_proc=subprocess.Popen([ "git", "config", "core.autocrlf" ],
Expand Down
4 changes: 2 additions & 2 deletions src/libgreen/sched.rs
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down Expand Up @@ -1364,7 +1364,7 @@ mod test {
});
}

// FIXME: #9407: xfail-test
// FIXME: #9407: ignore-test
#[ignore]
#[test]
fn dont_starve_1() {
Expand Down
4 changes: 2 additions & 2 deletions src/test/auxiliary/crateresolve7x.rs
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast
// ignore-fast
// aux-build:crateresolve_calories-1.rs
// aux-build:crateresolve_calories-2.rs

Expand Down
4 changes: 2 additions & 2 deletions src/test/auxiliary/issue-2414-b.rs
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast
// ignore-fast

#[crate_id="b#0.1"];
#[crate_type = "lib"];
Expand Down
4 changes: 2 additions & 2 deletions src/test/auxiliary/issue-9906.rs
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast windows doesn't like extern mod
// ignore-fast windows doesn't like extern mod
// aux-build:issue-9906.rs

pub use other::FooBar;
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/core-set.rs
@@ -1,6 +1,6 @@
// xfail-pretty
// ignore-pretty

// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
2 changes: 1 addition & 1 deletion src/test/bench/shootout-fannkuch-redux.rs
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test reading from os::args()[1] - bogus!
// ignore-test reading from os::args()[1] - bogus!

use std::from_str::FromStr;
use std::os;
Expand Down
2 changes: 1 addition & 1 deletion src/test/bench/shootout-fasta-redux.rs
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test reading from os::args()[1] - bogus!
// ignore-test reading from os::args()[1] - bogus!

use std::cast::transmute;
use std::from_str::FromStr;
Expand Down
6 changes: 3 additions & 3 deletions src/test/bench/shootout-k-nucleotide-pipes.rs
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,9 +8,9 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-android: FIXME(#10393)
// ignore-android: FIXME(#10393)

// xfail-pretty the `let to_child` line gets an extra newline
// ignore-pretty the `let to_child` line gets an extra newline
// multi tasking k-nucleotide

extern mod extra;
Expand Down
2 changes: 1 addition & 1 deletion src/test/bench/shootout-k-nucleotide.rs
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// ignore-test

extern mod extra;

Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/shootout-reverse-complement.rs
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-android doesn't terminate?
// ignore-android doesn't terminate?

use std::iter::range_step;
use std::io::{stdin, stdout, File};
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/shootout-spectralnorm.rs
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test arcs no longer unwrap
// ignore-test arcs no longer unwrap

extern mod sync;

Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/sudoku.rs
@@ -1,6 +1,6 @@
// xfail-pretty
// ignore-pretty

// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/task-perf-jargon-metal-smoke.rs
@@ -1,6 +1,6 @@
// xfail-pretty
// ignore-pretty

// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
6 changes: 3 additions & 3 deletions src/test/bench/task-perf-linked-failure.rs
Expand Up @@ -8,10 +8,10 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-pretty
// xfail-test linked failure
// ignore-pretty
// ignore-test linked failure

// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/task-perf-one-million.rs
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -10,7 +10,7 @@

// Test for concurrent tasks

// xfail-test OOM on linux-32 without opts
// ignore-test OOM on linux-32 without opts

use std::os;
use std::task;
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/ambig_impl_2_exe.rs
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast aux-build
// ignore-fast aux-build
// aux-build:ambig_impl_2_lib.rs
extern mod ambig_impl_2_lib;
use ambig_impl_2_lib::me;
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-in-bad-modifier.rs
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-out-assign-imm.rs
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-out-no-modifier.rs
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-out-read-uninit.rs
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/bad-char-literals3.rs
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-tidy-cr
// ignore-tidy-cr
fn main() {
// note that this is a literal "\r" byte
'
Expand Down

5 comments on commit f62460c

@bors
Copy link
Contributor

@bors bors commented on f62460c Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at fhahn@f62460c

@bors
Copy link
Contributor

@bors bors commented on f62460c Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging fhahn/rust/issue-11363-change-xfail = f62460c into auto

@bors
Copy link
Contributor

@bors bors commented on f62460c Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fhahn/rust/issue-11363-change-xfail = f62460c merged ok, testing candidate = 4c967e7

@bors
Copy link
Contributor

@bors bors commented on f62460c Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on f62460c Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 4c967e7

Please sign in to comment.