Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid flow-on Iterator error for
for ... in [ty err] {}
.
This squashes the > `for` loop expression has type `[type error]` which does not implement > the `Iterator` trait message that one received when writing `for ... in x` where was previously found to have a type error. Fixes #16042.
- Loading branch information
Showing
2 changed files
with
25 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
pub fn main() { | ||
let x = () + (); //~ ERROR binary operation | ||
|
||
// this shouldn't have a flow-on error: | ||
for _ in x {} | ||
} |
fd278a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at huonw@fd278a8
fd278a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging huonw/rust/for-error-nice = fd278a8 into auto
fd278a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huonw/rust/for-error-nice = fd278a8 merged ok, testing candidate = f6a7ab4
fd278a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1061
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1061
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1060
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1061
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1056
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1057
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1056
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1062
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1057
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1056
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1059
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1060
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1058
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1059
fd278a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = f6a7ab4