Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix ignore-logic for sanitizer run-make tests.
  • Loading branch information
michaelwoerister committed Apr 24, 2019
1 parent cc77087 commit ff976fe
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
5 changes: 2 additions & 3 deletions src/test/run-make-fulldeps/sanitizer-cdylib-link/Makefile
@@ -1,4 +1,6 @@
# needs-sanitizer-support
# only-x86_64
# only-linux

-include ../tools.mk

Expand All @@ -9,11 +11,8 @@ LOG := $(TMPDIR)/log.txt
# are compiled with address sanitizer, and we assert that a fault in the cdylib
# is correctly detected.

ifeq ($(TARGET),x86_64-unknown-linux-gnu)

# See comment in sanitizer-address/Makefile for why this is here
EXTRA_RUSTFLAG=-C relocation-model=dynamic-no-pic
endif

all:
$(RUSTC) -g -Z sanitizer=address --crate-type cdylib --target $(TARGET) $(EXTRA_RUSTFLAG) library.rs
Expand Down
4 changes: 2 additions & 2 deletions src/test/run-make-fulldeps/sanitizer-dylib-link/Makefile
@@ -1,4 +1,6 @@
# needs-sanitizer-support
# only-x86_64
# only-linux

-include ../tools.mk

Expand All @@ -9,10 +11,8 @@ LOG := $(TMPDIR)/log.txt
# are compiled with address sanitizer, and we assert that a fault in the dylib
# is correctly detected.

ifeq ($(TARGET),x86_64-unknown-linux-gnu)
# See comment in sanitizer-address/Makefile for why this is here
EXTRA_RUSTFLAG=-C relocation-model=dynamic-no-pic
endif

all:
$(RUSTC) -g -Z sanitizer=address --crate-type dylib --target $(TARGET) $(EXTRA_RUSTFLAG) library.rs
Expand Down
6 changes: 2 additions & 4 deletions src/test/run-make-fulldeps/sanitizer-staticlib-link/Makefile
@@ -1,15 +1,13 @@
# needs-sanitizer-support
# only-x86_64
# only-linux

-include ../tools.mk

# This test builds a staticlib, then an executable that links to it.
# The staticlib and executable both are compiled with address sanitizer,
# and we assert that a fault in the staticlib is correctly detected.

ifeq ($(TARGET),x86_64-unknown-linux-gnu)
EXTRA_RUSTFLAG=
endif

all:
$(RUSTC) -g -Z sanitizer=address --crate-type staticlib --target $(TARGET) library.rs
$(CC) program.c $(call STATICLIB,library) $(call OUT_EXE,program) $(EXTRACFLAGS) $(EXTRACXXFLAGS)
Expand Down

0 comments on commit ff976fe

Please sign in to comment.