Skip to content

Commit

Permalink
Update WR (types updates, stacking context culling)
Browse files Browse the repository at this point in the history
  • Loading branch information
gw3583 committed Mar 9, 2017
1 parent 2565242 commit 034feaf
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 38 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 1 addition & 17 deletions components/compositing/compositor.rs
Expand Up @@ -12,7 +12,7 @@ use euclid::point::TypedPoint2D;
use euclid::rect::TypedRect;
use euclid::scale_factor::ScaleFactor;
use euclid::size::TypedSize2D;
use gfx_traits::{Epoch, FragmentType, ScrollRootId};
use gfx_traits::{Epoch, ScrollRootId};
use gleam::gl;
use gleam::gl::types::{GLint, GLsizei};
use image::{DynamicImage, ImageFormat, RgbImage};
Expand Down Expand Up @@ -83,22 +83,6 @@ impl ConvertScrollRootIdFromWebRender for webrender_traits::ServoScrollRootId {
}
}

trait ConvertFragmentTypeFromWebRender {
fn from_webrender(&self) -> FragmentType;
}

impl ConvertFragmentTypeFromWebRender for webrender_traits::FragmentType {
fn from_webrender(&self) -> FragmentType {
match *self {
webrender_traits::FragmentType::FragmentBody => FragmentType::FragmentBody,
webrender_traits::FragmentType::BeforePseudoContent => {
FragmentType::BeforePseudoContent
}
webrender_traits::FragmentType::AfterPseudoContent => FragmentType::AfterPseudoContent,
}
}
}

/// Holds the state when running reftests that determines when it is
/// safe to save the output image.
#[derive(Copy, Clone, PartialEq)]
Expand Down
18 changes: 1 addition & 17 deletions components/layout/webrender_helpers.rs
Expand Up @@ -11,7 +11,7 @@ use app_units::Au;
use euclid::{Point2D, Rect, SideOffsets2D, Size2D};
use gfx::display_list::{BorderDetails, BorderRadii, BoxShadowClipMode, ClippingRegion};
use gfx::display_list::{DisplayItem, DisplayList, DisplayListTraversal, StackingContextType};
use gfx_traits::{FragmentType, ScrollRootId};
use gfx_traits::ScrollRootId;
use msg::constellation_msg::PipelineId;
use style::computed_values::{image_rendering, mix_blend_mode};
use style::computed_values::filter::{self, Filter};
Expand Down Expand Up @@ -421,19 +421,3 @@ impl WebRenderScrollRootIdConverter for ScrollRootId {
webrender_traits::ServoScrollRootId(self.0)
}
}

trait WebRenderFragmentTypeConverter {
fn convert_to_webrender(&self) -> webrender_traits::FragmentType;
}

impl WebRenderFragmentTypeConverter for FragmentType {
fn convert_to_webrender(&self) -> webrender_traits::FragmentType {
match *self {
FragmentType::FragmentBody => webrender_traits::FragmentType::FragmentBody,
FragmentType::BeforePseudoContent => {
webrender_traits::FragmentType::BeforePseudoContent
}
FragmentType::AfterPseudoContent => webrender_traits::FragmentType::AfterPseudoContent,
}
}
}
5 changes: 3 additions & 2 deletions components/servo/lib.rs
Expand Up @@ -99,6 +99,7 @@ use std::cmp::max;
use std::path::PathBuf;
use std::rc::Rc;
use std::sync::mpsc::Sender;
use webrender::renderer::RendererKind;
use webvr::{WebVRThread, WebVRCompositorHandler};

pub use gleam::gl;
Expand Down Expand Up @@ -159,9 +160,9 @@ impl<Window> Browser<Window> where Window: WindowMethods + 'static {
};

let renderer_kind = if opts::get().should_use_osmesa() {
webrender_traits::RendererKind::OSMesa
RendererKind::OSMesa
} else {
webrender_traits::RendererKind::Native
RendererKind::Native
};

let recorder = if opts.webrender_record {
Expand Down

0 comments on commit 034feaf

Please sign in to comment.