Implement nomodule attribute

servo · Jan 3, 2020 · 1cc6435 · 1cc6435
1 parent 5c9536a
commit 1cc6435
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/components/script/dom/htmlscriptelement.rs b/components/script/dom/htmlscriptelement.rs
@@ -447,7 +447,10 @@ impl HTMLScriptElement {
             return;
         }
 
-        // TODO: Step 12: nomodule content attribute
+        // Step 12
+        if element.has_attribute(&local_name!("nomodule")) && script_type == ScriptType::Classic {
+            return;
+        }
 
         // Step 13.
         if !element.has_attribute(&local_name!("src")) &&
@@ -1062,6 +1065,11 @@ impl HTMLScriptElementMethods for HTMLScriptElement {
     // https://html.spec.whatwg.org/multipage/#dom-script-defer
     make_bool_setter!(SetDefer, "defer");
 
+    // https://html.spec.whatwg.org/multipage/#dom-script-nomodule
+    make_bool_getter!(NoModule, "nomodule");
+    // https://html.spec.whatwg.org/multipage/#dom-script-nomodule
+    make_bool_setter!(SetNoModule, "nomodule");
+
     // https://html.spec.whatwg.org/multipage/#dom-script-integrity
     make_getter!(Integrity, "integrity");
     // https://html.spec.whatwg.org/multipage/#dom-script-integrity

diff --git a/components/script/dom/webidls/HTMLScriptElement.webidl b/components/script/dom/webidls/HTMLScriptElement.webidl
@@ -11,6 +11,8 @@ interface HTMLScriptElement : HTMLElement {
            attribute USVString src;
   [CEReactions]
            attribute DOMString type;
+  [CEReactions]
+           attribute boolean noModule;
   [CEReactions]
            attribute DOMString charset;
   [CEReactions]