Skip to content

Commit

Permalink
Make the password input element show the correct number of dots for m…
Browse files Browse the repository at this point in the history
…ultibyte chars.
  • Loading branch information
ema-fox committed Dec 5, 2014
1 parent 0316100 commit 1ecbe02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/script/dom/htmlinputelement.rs
Expand Up @@ -115,7 +115,7 @@ impl LayoutHTMLInputElementHelpers for JS<HTMLInputElement> {
.unwrap_or_else(|| "".to_string()),
InputPassword => {
let raw = get_raw_textinput_value(self);
String::from_char(raw.len(), '●')
String::from_char(raw.char_len(), '●')
}
_ => get_raw_textinput_value(self),
}
Expand Down

5 comments on commit 1ecbe02

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from jdm
at ema-fox@1ecbe02

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging ema-fox/servo/password_input = 1ecbe02 into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ema-fox/servo/password_input = 1ecbe02 merged ok, testing candidate = d5c62ac

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = d5c62ac

Please sign in to comment.