Throw on bad ByteStrings

servo · Oct 14, 2015 · 3129fb2 · 3129fb2
1 parent e733a7c
commit 3129fb2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/components/script/dom/bindings/conversions.rs b/components/script/dom/bindings/conversions.rs
@@ -577,7 +577,7 @@ impl FromJSValConvertible for ByteString {
             let char_vec = slice::from_raw_parts(chars, length as usize);
 
             if char_vec.iter().any(|&c| c > 0xFF) {
-                // XXX Throw
+                throw_type_error(cx, "Invalid ByteString");
                 Err(())
             } else {
                 Ok(ByteString::new(char_vec.iter().map(|&c| c as u8).collect()))

diff --git a/tests/wpt/metadata/XMLHttpRequest/setrequestheader-bogus-name.htm.ini b/tests/wpt/metadata/XMLHttpRequest/setrequestheader-bogus-name.htm.ini
@@ -0,0 +1,8 @@
+[setrequestheader-bogus-name.htm]
+  type: testharness
+  [setRequestHeader should throw with header name "ﾃｽﾄ".]
+    expected: FAIL
+
+  [setRequestHeader should throw with header name "X-ﾃｽﾄ".]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/XMLHttpRequest/setrequestheader-bogus-value.htm.ini b/tests/wpt/metadata/XMLHttpRequest/setrequestheader-bogus-value.htm.ini
@@ -0,0 +1,5 @@
+[setrequestheader-bogus-value.htm]
+  type: testharness
+  [XMLHttpRequest: setRequestHeader() value argument checks 4]
+    expected: FAIL
+