Convert a method from &JSRef to JSRef

This also removes the unnecessary formation of a trait object.
servo · Sep 30, 2014 · 3953456 · 3953456 · bors-servo · Oct 1, 2014
1 parent 698b916
commit 3953456
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs
@@ -238,16 +238,16 @@ impl LayoutElementHelpers for JS<Element> {
 }
 
 pub trait ElementHelpers {
-    fn html_element_in_html_document(&self) -> bool;
+    fn html_element_in_html_document(self) -> bool;
     fn get_local_name<'a>(&'a self) -> &'a Atom;
     fn get_namespace<'a>(&'a self) -> &'a Namespace;
     fn summarize(self) -> Vec<AttrInfo>;
     fn is_void(self) -> bool;
 }
 
 impl<'a> ElementHelpers for JSRef<'a, Element> {
-    fn html_element_in_html_document(&self) -> bool {
-        let node: JSRef<Node> = NodeCast::from_ref(*self);
+    fn html_element_in_html_document(self) -> bool {
+        let node: JSRef<Node> = NodeCast::from_ref(self);
         self.namespace == ns!(HTML) && node.is_in_html_doc()
     }
 

diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs
@@ -2086,8 +2086,7 @@ impl<'a> style::TNode<'a, JSRef<'a, Element>> for JSRef<'a, Node> {
     fn is_html_element_in_html_document(&self) -> bool {
         let elem: Option<JSRef<'a, Element>> = ElementCast::to_ref(*self);
         assert!(elem.is_some());
-        let elem: &ElementHelpers = &elem.unwrap() as &ElementHelpers;
-        elem.html_element_in_html_document()
+        elem.unwrap().html_element_in_html_document()
     }
 }