Added missing NavigatorId attributes

servo · Jun 11, 2019 · 4cfd62a · 4cfd62a
1 parent b3eed5b
commit 4cfd62a
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 0 deletions.
diff --git a/components/script/dom/navigator.rs b/components/script/dom/navigator.rs
@@ -66,6 +66,21 @@ impl NavigatorMethods for Navigator {
         navigatorinfo::Product()
     }
 
+    // https://html.spec.whatwg.org/multipage/#dom-navigator-productsub
+    fn ProductSub(&self) -> DOMString {
+        navigatorinfo::ProductSub()
+    }
+
+    // https://html.spec.whatwg.org/multipage/#dom-navigator-vendor
+    fn Vendor(&self) -> DOMString {
+        navigatorinfo::Vendor()
+    }
+
+    // https://html.spec.whatwg.org/multipage/#dom-navigator-vendorsub
+    fn VendorSub(&self) -> DOMString {
+        navigatorinfo::VendorSub()
+    }
+
     // https://html.spec.whatwg.org/multipage/#dom-navigator-taintenabled
     fn TaintEnabled(&self) -> bool {
         navigatorinfo::TaintEnabled()

diff --git a/components/script/dom/navigatorinfo.rs b/components/script/dom/navigatorinfo.rs
@@ -9,6 +9,18 @@ pub fn Product() -> DOMString {
     DOMString::from("Gecko")
 }
 
+pub fn ProductSub() -> DOMString {
+    DOMString::from("20100101")
+}
+
+pub fn Vendor() -> DOMString {
+    DOMString::from("")
+}
+
+pub fn VendorSub() -> DOMString {
+    DOMString::from("")
+}
+
 pub fn TaintEnabled() -> bool {
     false
 }

diff --git a/components/script/dom/webidls/Navigator.webidl b/components/script/dom/webidls/Navigator.webidl
@@ -22,8 +22,11 @@ interface NavigatorID {
   readonly attribute DOMString appVersion;
   readonly attribute DOMString platform;
   readonly attribute DOMString product; // constant "Gecko"
+  [Exposed=Window] readonly attribute DOMString productSub;
   boolean taintEnabled(); // constant false
   readonly attribute DOMString userAgent;
+  [Exposed=Window] readonly attribute DOMString vendor;
+  [Exposed=Window] readonly attribute DOMString vendorSub; // constant ""
 };
 
 // https://webbluetoothcg.github.io/web-bluetooth/#navigator-extensions

diff --git a/components/script/dom/workernavigator.rs b/components/script/dom/workernavigator.rs
@@ -42,6 +42,21 @@ impl WorkerNavigatorMethods for WorkerNavigator {
         navigatorinfo::Product()
     }
 
+    // https://html.spec.whatwg.org/multipage/#dom-navigator-productsub
+    fn ProductSub(&self) -> DOMString {
+        navigatorinfo::ProductSub()
+    }
+
+    // https://html.spec.whatwg.org/multipage/#dom-navigator-vendor
+    fn Vendor(&self) -> DOMString {
+        navigatorinfo::Vendor()
+    }
+
+    // https://html.spec.whatwg.org/multipage/#dom-navigator-vendorsub
+    fn VendorSub(&self) -> DOMString {
+        navigatorinfo::VendorSub()
+    }
+
     // https://html.spec.whatwg.org/multipage/#dom-navigator-taintenabled
     fn TaintEnabled(&self) -> bool {
         navigatorinfo::TaintEnabled()