Skip to content

Commit

Permalink
script: change requestAnimationFrame returns the unsigned long type.
Browse files Browse the repository at this point in the history
  • Loading branch information
tetsuharuohzeki committed Sep 4, 2015
1 parent 05deb3d commit 6362740
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions components/script/dom/document.rs
Expand Up @@ -142,11 +142,11 @@ pub struct Document {
scripting_enabled: Cell<bool>,
/// https://html.spec.whatwg.org/multipage/#animation-frame-callback-identifier
/// Current identifier of animation frame callback
animation_frame_ident: Cell<i32>,
animation_frame_ident: Cell<u32>,
/// https://html.spec.whatwg.org/multipage/#list-of-animation-frame-callbacks
/// List of animation frame callbacks
#[ignore_heap_size_of = "closures are hard"]
animation_frame_list: RefCell<HashMap<i32, Box<FnBox(f64)>>>,
animation_frame_list: RefCell<HashMap<u32, Box<FnBox(f64)>>>,
/// Tracks all outstanding loads related to this document.
loader: DOMRefCell<DocumentLoader>,
/// The current active HTML parser, to allow resuming after interruptions.
Expand Down Expand Up @@ -870,7 +870,7 @@ impl Document {
}

/// https://html.spec.whatwg.org/multipage/#dom-window-requestanimationframe
pub fn request_animation_frame(&self, callback: Box<FnBox(f64)>) -> i32 {
pub fn request_animation_frame(&self, callback: Box<FnBox(f64)>) -> u32 {
let window = self.window.root();
let window = window.r();
let ident = self.animation_frame_ident.get() + 1;
Expand All @@ -888,7 +888,7 @@ impl Document {
}

/// https://html.spec.whatwg.org/multipage/#dom-window-cancelanimationframe
pub fn cancel_animation_frame(&self, ident: i32) {
pub fn cancel_animation_frame(&self, ident: u32) {
self.animation_frame_list.borrow_mut().remove(&ident);
if self.animation_frame_list.borrow().is_empty() {
let window = self.window.root();
Expand Down
4 changes: 2 additions & 2 deletions components/script/dom/webidls/Window.webidl
Expand Up @@ -56,8 +56,8 @@
//void print();
//any showModalDialog(DOMString url, optional any argument);

long requestAnimationFrame(FrameRequestCallback callback);
void cancelAnimationFrame(long handle);
unsigned long requestAnimationFrame(FrameRequestCallback callback);
void cancelAnimationFrame(unsigned long handle);

//void postMessage(any message, DOMString targetOrigin, optional sequence<Transferable> transfer);

Expand Down
4 changes: 2 additions & 2 deletions components/script/dom/window.rs
Expand Up @@ -535,7 +535,7 @@ impl WindowMethods for Window {
}

/// https://html.spec.whatwg.org/multipage/#dom-window-requestanimationframe
fn RequestAnimationFrame(&self, callback: Rc<FrameRequestCallback>) -> i32 {
fn RequestAnimationFrame(&self, callback: Rc<FrameRequestCallback>) -> u32 {
let doc = self.Document();

let callback = move |now: f64| {
Expand All @@ -548,7 +548,7 @@ impl WindowMethods for Window {
}

/// https://html.spec.whatwg.org/multipage/#dom-window-cancelanimationframe
fn CancelAnimationFrame(&self, ident: i32) {
fn CancelAnimationFrame(&self, ident: u32) {
let doc = self.Document();
doc.r().cancel_animation_frame(ident);
}
Expand Down

0 comments on commit 6362740

Please sign in to comment.