Check Gecko pref before parsing frames() timing function

servo · Jul 11, 2017 · 8daeeb1 · 8daeeb1
1 parent 6320702
commit 8daeeb1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/components/style/gecko/generated/bindings.rs b/components/style/gecko/generated/bindings.rs
@@ -803,6 +803,9 @@ extern "C" {
                                           ComputedTimingFunction_BeforeFlag)
      -> f64;
 }
+extern "C" {
+    pub fn Gecko_IsFramesTimingEnabled() -> bool;
+}
 extern "C" {
     pub fn Gecko_AnimationGetBaseStyle(aBaseStyles:
                                            *mut ::std::os::raw::c_void,

diff --git a/components/style/values/specified/transform.rs b/components/style/values/specified/transform.rs
@@ -131,6 +131,17 @@ impl<S> OriginComponent<S> {
     }
 }
 
+#[cfg(feature = "gecko")]
+#[inline]
+fn allow_frames_timing() -> bool {
+    use gecko_bindings::bindings;
+    unsafe { bindings::Gecko_IsFramesTimingEnabled() }
+}
+
+#[cfg(feature = "servo")]
+#[inline]
+fn allow_frames_timing() -> bool { true }
+
 impl Parse for TimingFunction {
     fn parse<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>) -> Result<Self, ParseError<'i>> {
         if let Ok(keyword) = input.try(TimingKeyword::parse) {
@@ -172,8 +183,12 @@ impl Parse for TimingFunction {
                     Ok(GenericTimingFunction::Steps(steps, position))
                 },
                 "frames" => {
-                    let frames = Integer::parse_with_minimum(context, i, 2)?;
-                    Ok(GenericTimingFunction::Frames(frames))
+                    if allow_frames_timing() {
+                        let frames = Integer::parse_with_minimum(context, i, 2)?;
+                        Ok(GenericTimingFunction::Frames(frames))
+                    } else {
+                        Err(())
+                    }
                 },
                 _ => Err(()),
             }).map_err(|()| StyleParseError::UnexpectedFunction(function).into())