Skip to content

Commit

Permalink
Split Page code out of script_task.rs #2530
Browse files Browse the repository at this point in the history
  • Loading branch information
ebalint committed Jun 13, 2014
1 parent 4c5437c commit 94ec3cd
Show file tree
Hide file tree
Showing 8 changed files with 455 additions and 418 deletions.
4 changes: 2 additions & 2 deletions src/components/script/dom/bindings/codegen/CodegenRust.py
Expand Up @@ -4339,7 +4339,7 @@ def __init__(self, config, prefix, webIDLFile):
'dom::bindings::proxyhandler::{FillPropertyDescriptor, GetExpandoObject}',
'dom::bindings::proxyhandler::{getPropertyDescriptor}',
'dom::bindings::str::ByteString',
'script_task::JSPageInfo',
'page::JSPageInfo',
'libc',
'servo_util::str::DOMString',
'std::mem',
Expand Down Expand Up @@ -5214,7 +5214,7 @@ def RegisterBindings(config):
'dom::bindings::codegen',
'dom::bindings::js::{JS, JSRef}',
'dom::window::Window',
'script_task::JSPageInfo',
'page::JSPageInfo',
])

@staticmethod
Expand Down
2 changes: 1 addition & 1 deletion src/components/script/dom/htmliframeelement.rs
Expand Up @@ -14,7 +14,7 @@ use dom::htmlelement::HTMLElement;
use dom::node::{Node, ElementNodeTypeId, window_from_node};
use dom::virtualmethods::VirtualMethods;
use dom::window::Window;
use script_task::IterablePage;
use page::IterablePage;
use servo_msg::constellation_msg::{PipelineId, SubpageId};
use servo_msg::constellation_msg::{IFrameSandboxed, IFrameUnsandboxed};
use servo_msg::constellation_msg::{ConstellationChan, LoadIframeUrlMsg};
Expand Down
2 changes: 1 addition & 1 deletion src/components/script/dom/location.rs
Expand Up @@ -8,7 +8,7 @@ use dom::bindings::utils::{Reflectable, Reflector, reflect_dom_object};
use dom::window::Window;
use servo_util::str::DOMString;

use script_task::{Page};
use page::Page;
use std::rc::Rc;

use serialize::{Encoder, Encodable};
Expand Down
3 changes: 2 additions & 1 deletion src/components/script/dom/window.rs
Expand Up @@ -17,7 +17,8 @@ use dom::navigator::Navigator;
use dom::performance::Performance;

use layout_interface::{ReflowForDisplay, DocumentDamageLevel};
use script_task::{ExitWindowMsg, FireTimerMsg, Page, ScriptChan, TriggerLoadMsg, TriggerFragmentMsg};
use page::Page;
use script_task::{ExitWindowMsg, FireTimerMsg, ScriptChan, TriggerLoadMsg, TriggerFragmentMsg};
use servo_msg::compositor_msg::ScriptListener;
use servo_net::image_cache_task::ImageCacheTask;
use servo_util::str::DOMString;
Expand Down
2 changes: 1 addition & 1 deletion src/components/script/html/hubbub_html_parser.rs
Expand Up @@ -14,7 +14,7 @@ use dom::htmlformelement::HTMLFormElement;
use dom::node::{ElementNodeTypeId, NodeHelpers, NodeMethods};
use dom::types::*;
use html::cssparse::{StylesheetProvenance, UrlProvenance, spawn_css_parser};
use script_task::Page;
use page::Page;

use hubbub::hubbub;
use hubbub::hubbub::{NullNs, HtmlNs, MathMlNs, SvgNs, XLinkNs, XmlNs, XmlNsNs};
Expand Down

5 comments on commit 94ec3cd

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from jdm
at ebalint@94ec3cd

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging ebalint/servo/2530 = 94ec3cd into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ebalint/servo/2530 = 94ec3cd merged ok, testing candidate = c057610

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = c057610

Please sign in to comment.