Implement various checks on the Location setters

Implement various checks on the Location setters Set correct referrer url before for href location setter Update wpt-metadata for failing tests Try updating tests/wpt/metadata/url/failure.html.ini
servo · Apr 24, 2020 · b10de77 · b10de77
1 parent 412bc1c
commit b10de77
Show file tree

Hide file tree

Showing 9 changed files with 239 additions and 215 deletions.
diff --git a/components/script/dom/location.rs b/components/script/dom/location.rs
diff --git a/tests/wpt/metadata/fullscreen/api/document-exit-fullscreen-active-document.html.ini b/tests/wpt/metadata/fullscreen/api/document-exit-fullscreen-active-document.html.ini
diff --git a/tests/wpt/metadata/html/browsers/browsing-the-web/navigating-across-documents/005.html.ini b/tests/wpt/metadata/html/browsers/browsing-the-web/navigating-across-documents/005.html.ini
@@ -1,3 +1,4 @@
 [005.html]
-  type: testharness
-  expected: ERROR
+  [Link with onclick navigation and href navigation ]
+    expected: FAIL
+
diff --git a/...data/html/browsers/browsing-the-web/unloading-documents/beforeunload-synchronous.html.ini b/...data/html/browsers/browsing-the-web/unloading-documents/beforeunload-synchronous.html.ini
diff --git a/...rowsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html.ini b/...rowsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html.ini
diff --git a/...html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html.ini b/...html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html.ini
@@ -1,29 +1,5 @@
 [location-protocol-setter-non-broken.html]
   type: testharness
-  [Set data URL frame location.protocol to gopher]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to gopher]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to data]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to x]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to http+x]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to ftp]
-    expected: FAIL
-
-  [Set data URL frame location.protocol to x]
-    expected: FAIL
-
-  [Set data URL frame location.protocol to data]
-    expected: FAIL
-
   [Set data URL frame location.protocol to ftp]
     expected: FAIL
 

diff --git a/...t/metadata/html/browsers/history/the-location-interface/location-protocol-setter.html.ini b/...t/metadata/html/browsers/history/the-location-interface/location-protocol-setter.html.ini
@@ -1,35 +1,5 @@
 [location-protocol-setter.html]
   type: testharness
-  [%00 (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%01 (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%0A (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%20 (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [! (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%7F (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%C2%80 (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%C3%BF (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [: (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%E2%80%A0 (percent-encoded) is not a scheme]
-    expected: FAIL
-
   [%00x (percent-encoded) is not a scheme]
     expected: FAIL
 
@@ -42,21 +12,6 @@
   [%20x (percent-encoded) is not a scheme]
     expected: FAIL
 
-  [!x (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%7Fx (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%C2%80x (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%C3%BFx (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [:x (percent-encoded) is not a scheme]
-    expected: FAIL
-
   [%EF%BF%BD%EF%BF%BD%EF%BF%BDx (percent-encoded) is not a scheme]
     expected: FAIL
 
@@ -72,24 +27,6 @@
   [%20X (percent-encoded) is not a scheme]
     expected: FAIL
 
-  [!X (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%7FX (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%C2%80X (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%C3%BFX (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [:X (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [%E2%80%A0X (percent-encoded) is not a scheme]
-    expected: FAIL
-
   [x%00 (percent-encoded) is not a scheme]
     expected: FAIL
 
@@ -102,21 +39,6 @@
   [x%20 (percent-encoded) is not a scheme]
     expected: FAIL
 
-  [x! (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [x%7F (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [x%C2%80 (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [x%C3%BF (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [x%E2%80%A0 (percent-encoded) is not a scheme]
-    expected: FAIL
-
   [X%00 (percent-encoded) is not a scheme]
     expected: FAIL
 
@@ -129,21 +51,6 @@
   [X%20 (percent-encoded) is not a scheme]
     expected: FAIL
 
-  [X! (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [X%7F (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [X%C2%80 (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [X%C3%BF (percent-encoded) is not a scheme]
-    expected: FAIL
-
-  [X%E2%80%A0 (percent-encoded) is not a scheme]
-    expected: FAIL
-
   [a%0A (percent-encoded) is not a scheme]
     expected: FAIL
 
@@ -153,6 +60,3 @@
   [Equivalent tests for data URL and srcdoc <iframe>s]
     expected: FAIL
 
-  [%E2%80%A0x (percent-encoded) is not a scheme]
-    expected: FAIL
-
diff --git a/...t/metadata/html/browsers/history/the-location-interface/no-browsing-context.window.js.ini b/...t/metadata/html/browsers/history/the-location-interface/no-browsing-context.window.js.ini
@@ -1,34 +1,19 @@
 [no-browsing-context.window.html]
-  [Invoking `assign` with `/` on a `Location` object sans browsing context is a no-op]
-    expected: FAIL
-
-  [Invoking `replace` with `/` on a `Location` object sans browsing context is a no-op]
+  [Setting `protocol` to `http` of a `Location` object sans browsing context is a no-op]
     expected: FAIL
 
   [Setting `hash` to `test` of a `Location` object sans browsing context is a no-op]
     expected: FAIL
 
-  [Setting `href` to `test test` of a `Location` object sans browsing context is a no-op]
-    expected: FAIL
-
   [Invoking `replace` with `http://test:test/` on a `Location` object sans browsing context is a no-op]
     expected: FAIL
 
-  [Invoking `assign` with `test test` on a `Location` object sans browsing context is a no-op]
-    expected: FAIL
-
   [Getting `ancestorOrigins` of a `Location` object sans browsing context should be [\]]
     expected: FAIL
 
   [Invoking `assign` with `http://test:test/` on a `Location` object sans browsing context is a no-op]
     expected: FAIL
 
-  [Setting `href` to `/` of a `Location` object sans browsing context is a no-op]
-    expected: FAIL
-
   [Setting `href` to `http://test:test/` of a `Location` object sans browsing context is a no-op]
     expected: FAIL
 
-  [Invoking `replace` with `test test` on a `Location` object sans browsing context is a no-op]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/url/failure.html.ini b/tests/wpt/metadata/url/failure.html.ini
@@ -129,6 +129,39 @@
   [Location's href: sc://te@s:t@/ should throw]
     expected: FAIL
 
+  [Location's href: http:/:@/www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: http:@/www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: http:/@/www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: http:a:b@/www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: http:/a:b@/www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: http::@/www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: http:@:www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: http:/@:www.example.com should throw]
+    expected: FAIL
+
+  [Location's href: a should throw]
+    expected: FAIL
+
+  [Location's href: a/ should throw]
+    expected: FAIL
+
+  [Location's href: a// should throw]
+    expected: FAIL
+
   [window.open(): sc://te@s:t@/ should throw]
     expected: FAIL