Skip to content

Commit

Permalink
Replace compiletest suite by doc-tests with compile_fail
Browse files Browse the repository at this point in the history
compiletest-rs use internal rustc APIs and is broken in today’s Nightly.
rustdoc however is maintained with rustc and so much less fragile.
  • Loading branch information
SimonSapin committed Nov 22, 2017
1 parent d96f0ff commit b1ce298
Show file tree
Hide file tree
Showing 18 changed files with 266 additions and 239 deletions.
54 changes: 25 additions & 29 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion etc/ci/buildbot_steps.yml
Expand Up @@ -80,7 +80,6 @@ linux-dev:
- ./mach test-tidy --no-progress --all
- ./mach test-tidy --no-progress --self-test
- env CC=gcc-5 CXX=g++-5 ./mach build --dev
- env ./mach test-compiletest
- env ./mach test-unit
- env ./mach package --dev
- env ./mach build-cef
Expand Down
5 changes: 3 additions & 2 deletions ports/servo/Cargo.toml
Expand Up @@ -14,16 +14,17 @@ test = false
bench = false

[dev-dependencies]
compiletest_helper = {path = "../../tests/compiletest/helper"}
deny_public_fields_tests = {path = "../../tests/unit/deny_public_fields"}
gfx_tests = {path = "../../tests/unit/gfx"}
layout_tests = {path = "../../tests/unit/layout"}
malloc_size_of_tests = {path = "../../tests/unit/malloc_size_of"}
metrics_tests = {path = "../../tests/unit/metrics"}
msg_tests = {path = "../../tests/unit/msg"}
net_tests = {path = "../../tests/unit/net"}
net_traits_tests = {path = "../../tests/unit/net_traits"}
plugin_compiletest = {path = "../../tests/compiletest/plugin"}
profile_tests = {path = "../../tests/unit/profile"}
script_tests = {path = "../../tests/unit/script"}
script_plugins_tests = {path = "../../tests/unit/script_plugins"}
servo_config_tests = {path = "../../tests/unit/servo_config"}
servo_remutex_tests = {path = "../../tests/unit/servo_remutex"}
style_tests = {path = "../../tests/unit/style"}
Expand Down
61 changes: 0 additions & 61 deletions python/servo/testing_commands.py
Expand Up @@ -59,9 +59,6 @@
("unit", {"kwargs": {},
"paths": [path.abspath(path.join("tests", "unit"))],
"include_arg": "test_name"}),
("compiletest", {"kwargs": {"release": False},
"paths": [path.abspath(path.join("tests", "compiletest"))],
"include_arg": "test_name"})
])

TEST_SUITES_BY_PREFIX = {path: k for k, v in TEST_SUITES.iteritems() if "paths" in v for path in v["paths"]}
Expand Down Expand Up @@ -117,7 +114,6 @@ def test(self, params, render_mode=DEFAULT_RENDER_MODE, release=False, tidy_all=
"stylo": False}
suites["wpt"]["kwargs"] = {"release": release}
suites["unit"]["kwargs"] = {}
suites["compiletest"]["kwargs"] = {"release": release}

selected_suites = OrderedDict()

Expand Down Expand Up @@ -302,63 +298,6 @@ def test_stylo(self, release=False, test_name=None):
with cd(path.join("ports", "geckolib")):
return call(args, env=env)

@Command('test-compiletest',
description='Run compiletests',
category='testing')
@CommandArgument('--package', '-p', default=None, help="Specific package to test")
@CommandArgument('test_name', nargs=argparse.REMAINDER,
help="Only run tests that match this pattern or file path")
@CommandArgument('--release', default=False, action="store_true",
help="Run with a release build of servo")
def test_compiletest(self, test_name=None, package=None, release=False):
if test_name is None:
test_name = []

self.ensure_bootstrapped()

if package:
packages = {package}
else:
packages = set()

test_patterns = []
for test in test_name:
# add package if 'tests/compiletest/<package>'
match = re.search("tests/compiletest/(\\w+)/?$", test)
if match:
packages.add(match.group(1))
# add package & test if '<package>/<test>', 'tests/compiletest/<package>/<test>.rs', or similar
elif re.search("\\w/\\w", test):
tokens = test.split("/")
packages.add(tokens[-2])
test_prefix = tokens[-1]
if test_prefix.endswith(".rs"):
test_prefix = test_prefix[:-3]
test_prefix += "::"
test_patterns.append(test_prefix)
# add test as-is otherwise
else:
test_patterns.append(test)

if not packages:
packages = set(os.listdir(path.join(self.context.topdir, "tests", "compiletest"))) - set(['.DS_Store'])

packages.remove("helper")

args = ["cargo", "test"]
for crate in packages:
args += ["-p", "%s_compiletest" % crate]
args += test_patterns

env = self.build_env()
if release:
env["BUILD_MODE"] = "release"
args += ["--release"]
else:
env["BUILD_MODE"] = "debug"

return call(args, env=env, cwd=self.servo_crate())

@Command('test-content',
description='Run the content tests',
category='testing')
Expand Down
28 changes: 0 additions & 28 deletions tests/compiletest/helper/lib.rs

This file was deleted.

16 changes: 0 additions & 16 deletions tests/compiletest/plugin/Cargo.toml

This file was deleted.

This file was deleted.

This file was deleted.

27 changes: 0 additions & 27 deletions tests/compiletest/plugin/compile-fail/unrooted_must_root.rs

This file was deleted.

10 changes: 0 additions & 10 deletions tests/compiletest/plugin/lib.rs

This file was deleted.

12 changes: 12 additions & 0 deletions tests/unit/deny_public_fields/Cargo.toml
@@ -0,0 +1,12 @@
[package]
name = "deny_public_fields_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
path = "lib.rs"
test = false

[dependencies]
deny_public_fields = {path = "../../../components/deny_public_fields"}

0 comments on commit b1ce298

Please sign in to comment.