Navigation Menu

Skip to content

Commit

Permalink
Fix BluetoothPermissionResult return state
Browse files Browse the repository at this point in the history
  • Loading branch information
dati91 committed Feb 13, 2017
1 parent f7e86d2 commit b1d388a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions components/script/dom/bluetooth.rs
Expand Up @@ -215,12 +215,12 @@ impl Bluetooth {
let option = RequestDeviceoptions::new(BluetoothScanfilterSequence::new(uuid_filters),
ServiceUUIDSequence::new(optional_services_uuids));

// Step 3 - 5
// Step 4 - 5.
if let PermissionState::Denied = get_descriptor_permission_state(PermissionName::Bluetooth, None) {
return p.reject_error(p.global().get_cx(), Error::NotFound);
}

// Note: Steps 6 - 8 are implemented in
// Note: Step 3, 6 - 8 are implemented in
// components/net/bluetooth_thread.rs in request_device function.
self.get_bluetooth_thread().send(BluetoothRequest::RequestDevice(option, sender)).unwrap();
}
Expand Down
3 changes: 2 additions & 1 deletion components/script/dom/bluetoothpermissionresult.rs
Expand Up @@ -87,8 +87,9 @@ impl AsyncBluetoothListener for BluetoothPermissionResult {
fn handle_response(&self, response: BluetoothResponse, promise_cx: *mut JSContext, promise: &Rc<Promise>) {
match response {
// https://webbluetoothcg.github.io/web-bluetooth/#request-bluetooth-devices
// Step 11, 13 - 14.
// Step 3, 11, 13 - 14.
BluetoothResponse::RequestDevice(device) => {
self.set_state(PermissionState::Granted);
let bluetooth = self.get_bluetooth();
let mut device_instance_map = bluetooth.get_device_map().borrow_mut();
if let Some(ref existing_device) = device_instance_map.get(&device.id) {
Expand Down

0 comments on commit b1d388a

Please sign in to comment.