Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Add comment about incorrect tests for file url range requests. Fmt an…
…d manifest update
  • Loading branch information
ferjm committed Nov 26, 2018
1 parent 4561a97 commit b23dd05
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 13 deletions.
3 changes: 2 additions & 1 deletion components/net/fetch/methods.rs
Expand Up @@ -610,7 +610,8 @@ fn scheme_fetch(
Err(_) => None,
};

let mut response = Response::new(url, ResourceFetchTiming::new(request.timing_type()));
let mut response =
Response::new(url, ResourceFetchTiming::new(request.timing_type()));

let range_header = request.headers.typed_get::<Range>();
let is_range_request = range_header.is_some();
Expand Down
3 changes: 2 additions & 1 deletion components/net/tests/fetch.rs
Expand Up @@ -36,7 +36,8 @@ use net::test::HttpState;
use net_traits::request::{Destination, Origin, RedirectMode, Referrer, Request, RequestMode};
use net_traits::response::{CacheState, Response, ResponseBody, ResponseType};
use net_traits::{
FetchTaskTarget, IncludeSubdomains, NetworkError, ReferrerPolicy, ResourceFetchTiming, ResourceTimingType,
FetchTaskTarget, IncludeSubdomains, NetworkError, ReferrerPolicy, ResourceFetchTiming,
ResourceTimingType,
};
use servo_url::{ImmutableOrigin, ServoUrl};
use std::fs::File;
Expand Down
22 changes: 11 additions & 11 deletions tests/wpt/mozilla/meta/MANIFEST.json
Expand Up @@ -14269,13 +14269,13 @@
"/_mozilla/mozilla/range_deleteContents.html",
{}
]
],
],
"mozilla/range_request_blob_url.html": [
[
"/_mozilla/mozilla/range_request_blob_url.html",
"/_mozilla/mozilla/range_request_blob_url.html",
{}
]
],
],
"mozilla/range_request_file_url.html": [
[
"/_mozilla/mozilla/range_request_file_url.html",
Expand Down Expand Up @@ -27070,15 +27070,15 @@
"testharness"
],
"mozilla/interfaces.html": [
"ad17e930ddb5bc2daecb86216efe8885ae399173",
"ad17e930ddb5bc2daecb86216efe8885ae399173",
"testharness"
],
"mozilla/interfaces.js": [
"6f2a54524ef317a48d758f7e50f742fd9b3a93e4",
"support"
],
"mozilla/interfaces.worker.js": [
"a5f2e00f234ea66b80e8a9bd4dbbc5433926191f",
"a5f2e00f234ea66b80e8a9bd4dbbc5433926191f",
"testharness"
],
"mozilla/invalid-this.html": [
Expand Down Expand Up @@ -27244,13 +27244,13 @@
"mozilla/range_deleteContents.html": [
"8de03455bcb0d18258f76af20f58c14868fe1c21",
"testharness"
],
],
"mozilla/range_request_blob_url.html": [
"075397620e989dafc814c0ed2bca46bd476bccf6",
"075397620e989dafc814c0ed2bca46bd476bccf6",
"testharness"
],
],
"mozilla/range_request_file_url.html": [
"65fe13fe93d97cebc2846ff7d7deab3eb84c1787",
"4fd4ddc8b1a9959e90b243795267c220d6a05f5e",
"testharness"
],
"mozilla/referrer-policy/OWNERS": [
Expand Down Expand Up @@ -32914,11 +32914,11 @@
"testharness"
],
"mozilla/window_performance.html": [
"690870b7080e179481ca0255f7c30337e8b6636a",
"690870b7080e179481ca0255f7c30337e8b6636a",
"testharness"
],
"mozilla/window_performance_topLevelDomComplete.html": [
"50bbc2917b5ac900b5061a0b2c30b6c1fef1067e",
"50bbc2917b5ac900b5061a0b2c30b6c1fef1067e",
"testharness"
],
"mozilla/window_requestAnimationFrame.html": [
Expand Down
4 changes: 4 additions & 0 deletions tests/wpt/mozilla/tests/mozilla/range_request_file_url.html
Expand Up @@ -3,6 +3,10 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>

// FIXME(ferjm) https://github.com/servo/servo/issues/22269
// This is not using file:// urls.

[{
file: "resources/range_small.txt",
range: "bytes=0-",
Expand Down

0 comments on commit b23dd05

Please sign in to comment.