Add support for default dict values being boolean, use in MediaStream…

…Constraints
servo · Mar 4, 2019 · ce635b7 · ce635b7
1 parent caa0594
commit ce635b7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py
@@ -747,7 +747,15 @@ def wrapObjectTemplate(templateBody, nullValue, isDefinitelyObject, type,
             for memberType in type.unroll().flatMemberTypes
             if memberType.isDictionary()
         ]
-        if dictionaries:
+        if defaultValue and not isinstance(defaultValue, IDLNullValue):
+            tag = defaultValue.type.tag()
+            if tag is IDLType.Tags.bool:
+                default = "%s::Boolean(%s)" % (
+                    union_native_type(type),
+                    "true" if defaultValue.value else "false")
+            else:
+                raise("We don't currently support default values that aren't null or boolean")
+        elif dictionaries:
             if defaultValue:
                 assert isinstance(defaultValue, IDLNullValue)
                 dictionary, = dictionaries

diff --git a/components/script/dom/webidls/MediaDevices.webidl b/components/script/dom/webidls/MediaDevices.webidl
@@ -23,10 +23,8 @@ partial interface MediaDevices {
 
 
 dictionary MediaStreamConstraints {
-        (boolean or MediaTrackConstraints) video;
-        // (boolean or MediaTrackConstraints) video = false;
-        (boolean or MediaTrackConstraints) audio;
-        // (boolean or MediaTrackConstraints) audio = false;
+        (boolean or MediaTrackConstraints) video = false;
+        (boolean or MediaTrackConstraints) audio = false;
 };
 
 dictionary DoubleRange {